Re: [PATCH v2 00/15] pwm: dt-bindings: Include generic pwm schema

Krzysztof Kozlowski
2022-02-15T08:00:30Z

On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> my last mail]
>
> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Changes since v1:
> > 1. Add tags.
> > 2. Adjust subject (Uwe).
>
> However you only took a part of my suggestion ...
>
> > Krzysztof Kozlowski (15):
> > dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> > dt-bindings: pwm: imx: Include generic pwm schema
> > dt-bindings: pwm: intel,lgm: Include generic pwm schema
> > dt-bindings: pwm: iqs620a: Include generic pwm schema
> > dt-bindings: pwm: mxs: Include generic pwm schema
> > dt-bindings: pwm: rockchip: Include generic pwm schema
> > dt-bindings: pwm: sifive: Include generic pwm schema
> > dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> > dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> > dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> > dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
>
> ... The actual patch has a space after the comma, I like this variant
> without comma better as this is a compatible string.

I am confused. My patch does not have comma after space. Your reply
had such in the subject, but not in the proposed new subject you wrote
in msg, so I left it as is. Without comma. If you still see comma, it
is something with your mail client.

See:
https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u

Also reply from Vijayakannan does not have comma:
https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec

> Also a # before
> pwm-cells would be nice.

I can add this.

Best regards,
Krzysztof