Re: [PATCH v2 00/15] pwm: dt-bindings: Include generic pwm schema

Uwe Kleine-König
2022-02-15T07:41:34Z

[-- Attachment #1.1: Type: text/plain, Size: 1367 bytes --]

Hello,

[dropped Anson Huang and Yash Shah from Cc: which were not reachable for
my last mail]

On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1:
> 1. Add tags.
> 2. Adjust subject (Uwe).

However you only took a part of my suggestion ...

> Krzysztof Kozlowski (15):
> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> dt-bindings: pwm: imx: Include generic pwm schema
> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> dt-bindings: pwm: iqs620a: Include generic pwm schema
> dt-bindings: pwm: mxs: Include generic pwm schema
> dt-bindings: pwm: rockchip: Include generic pwm schema
> dt-bindings: pwm: sifive: Include generic pwm schema
> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice

... The actual patch has a space after the comma, I like this variant
without comma better as this is a compatible string. Also a # before
pwm-cells would be nice.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]