From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19DB7CCFA13 for ; Wed, 29 Apr 2026 09:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LQezkEvk+gAaknKuJWsTBfmRQftS6V6pWj5AJVmzrRU=; b=iaAjj/7TXAjlE4 ENpWIXnNWU82blAeDNPerqIHVLRjKoAxEiYRo13vsII+s6RILLzg8KSg0m/VSrTpWNNHZU8/DwJJp wEOWAdmdP3Sfz2yVQu54rOVBYgtnG06yXmJvzvGBGhl0PzYF4L4LYum2hEhvevuUA/FVt0oxP8JEz LQGCcmwhz+oog9rhiuK7aGlk1uJzXuPIxt0aMg4kUVjKc/f1B/PVybCp548AzpsCkmUCebCnvsYaA A5TO/FOrSTgCV38sRoRMhV3NHiHlDeB6xWAshCHSBqT221lYqUZXE5x6kirJeYDSUKHrfwyvNZsJz mh3SduIiZon96hB1gqAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wI1fq-00000003PBi-2C4e; Wed, 29 Apr 2026 09:57:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wI1fp-00000003PB3-2ZDW; Wed, 29 Apr 2026 09:57:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=Umh2GNLzS0ZLJ1ouGA7sN5L/Audjee+GTfXIQgbar64=; b=L5hJk3io3fAVDZsT+P4P3sNFEy hvESbosUOG1UGwKYXVm4zuJrTY9hN5sECsgQbITGxfUhTPwub34eI6RIDToKb/XRmTu6yiDCyBobk LrGygpsUHyzWfaaSDwLtGI1aFOi9HtUsPENpDqbzNuCt3QiCzajSN22/BPD0ehFL4f+cK1aNu17t1 MTrxBTut9L5JXu4xL3PexvZjoaA3QzkrUdapfD2w0e1VED8eomjdml9oqM2KTSdhwolRJPBq0aMNa gdzX5Q2BC/xM6TR/+TehQf7fwYRMRDpitCYmgHC0qXiCn7zwa+loOx8dRPLaLCae6Z0pgKpclXiyS PtTtV7sQ==; Received: from linux.microsoft.com ([13.77.154.182]) by desiato.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wI1fl-000000052km-21HP; Wed, 29 Apr 2026 09:57:40 +0000 Received: from [10.95.65.160] (unknown [167.220.238.0]) by linux.microsoft.com (Postfix) with ESMTPSA id 5250A20B716C; Wed, 29 Apr 2026 02:57:25 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5250A20B716C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1777456652; bh=Umh2GNLzS0ZLJ1ouGA7sN5L/Audjee+GTfXIQgbar64=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q31XCOROwAjmtXRERBx2iF+/+sJsH2ybABfnJCzFn77NWB9EVyO4d6UDaaSUN2seb YQ7d0/CyN4ooJv9sS8ZRGDqMJBY896FQHOvEKQgI5tVaj4mJi2D6hDXN+gA0IZ5wgq 80ZbIizjLbl6bTb0czS/dH3jkSHeHVV2s6z/Ha8s= Message-ID: <80efa86b-de96-438c-ac04-fda22c655500@linux.microsoft.com> Date: Wed, 29 Apr 2026 15:27:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/15] Drivers: hv: Move hv_call_(get|set)_vp_registers() declarations To: Michael Kelley , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Marc Zyngier , Timothy Hayes , Lorenzo Pieralisi , Sascha Bischoff , mrigendrachaubey , "linux-hyperv@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "vdso@mailbox.org" , "ssengar@linux.microsoft.com" References: <20260423124206.2410879-1-namjain@linux.microsoft.com> <20260423124206.2410879-9-namjain@linux.microsoft.com> Content-Language: en-US From: Naman Jain In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260429_105737_860054_B9C3ABC8 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 4/27/2026 11:09 AM, Michael Kelley wrote: > From: Naman Jain Sent: Thursday, April 23, 2026 5:42 AM >> >> Move hv_call_get_vp_registers() and hv_call_set_vp_registers() >> declarations from drivers/hv/mshv.h to include/asm-generic/mshyperv.h. >> >> These functions are defined in mshv_common.c and are going to be called >> from both drivers/hv/ and arch/x86/hyperv/hv_vtl.c. The latter never >> included mshv.h, relying on implicit declaration visibility. Moving the >> declarations to the arch-generic Hyper-V header makes them properly >> visible to all architecture-specific callers. >> >> Provide static inline stubs returning -EOPNOTSUPP when neither >> CONFIG_MSHV_ROOT nor CONFIG_MSHV_VTL is enabled. > > Looking at the drivers/hv/Kconfig, it's possible to build with > CONFIG_HYPERV_VTL_MODE=y, but not CONFIG_MSHV_VTL. In such a > case, mshv_common.o doesn't get built, which is why the stubs are > needed. Is such a configuration desirable for some scenarios? > > I wonder if having CONFIG_HYPERV_VTL_MODE force the building of > mshv_common.o would be a better approach. Then the stubs wouldn't > be needed. The "ifneq" statement in drivers/hv/Makefile could use > CONFIG_HYPERV_VTL_MODE instead of CONFIG_MSHV_VTL, and > everything would be good since CONFIG_MSHV_VTL depends on > CONFIG_HYPERV_VTL_MODE. > This looks good. I'll try this and make the changes. In case there are some challenges with that, I'll revert back. Regards, Naman _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv