From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88BF6C71153 for ; Mon, 28 Aug 2023 07:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q3T8EwXZaVpH5y0cNDUT8ionQJIKkzJHWbpfLBw23lo=; b=em4aEc0E9YVLXa lEiJpzeldohEAZELNiGiEWUCej3SoK5JWXi/1wm6T7UFkaUiUzrQrqPIsMg237+cZn8UVVpDEP5Si Tf85XipOXpxXwjoWXqoy6zNaTerbDBRH+AQH/tEd8NbW2R8pCacNGe/m8zWK0BCZ/CbskczUVkmXh KINnFXLZ4DjP/pb7oS18YjFjoU1Ikg6Ag2JOxbL7hhEDs9EbSfOddDxgmzLwOXagAK2QVlWfLKtS9 HJNMtSlku3KN59gaDg4S6XQhK+NG+X1GOaWnMFR+8NNcoLvsRLpbMBYWT61D468qDfyoXeaZ5lQIq GpG0W4bwyrSImxhJtO6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaWz0-00951U-2F; Mon, 28 Aug 2023 07:48:22 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaWyw-0094zL-1j for linux-riscv@lists.infradead.org; Mon, 28 Aug 2023 07:48:20 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 77DBC7FDC; Mon, 28 Aug 2023 15:47:53 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 28 Aug 2023 15:47:53 +0800 Received: from [192.168.125.72] (113.72.145.245) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 28 Aug 2023 15:47:52 +0800 Message-ID: <8390fffb-c704-286f-44b9-4e0d24818343@starfivetech.com> Date: Mon, 28 Aug 2023 15:47:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [RFC v4 0/4] StarFive's Pulse Width Modulation driver support Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley , William Qiu CC: , , , , "Emil Renner Berthing" , Rob Herring , Philipp Zabel , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Krzysztof Kozlowski" , Conor Dooley , Paul Walmsley , "Palmer Dabbelt" , Albert Ou References: <20230825081328.204442-1-william.qiu@starfivetech.com> <20230825-exclusion-doing-93532be4fa97@spud> <683df184-6688-f006-c4d8-fa7000b7b771@linaro.org> From: Hal Feng In-Reply-To: <683df184-6688-f006-c4d8-fa7000b7b771@linaro.org> X-Originating-IP: [113.72.145.245] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230828_004818_719707_CDE7AF3C X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 8/28/2023 3:16 PM, Krzysztof Kozlowski wrote: > On 28/08/2023 09:12, Hal Feng wrote: >> On Fri, 25 Aug 2023 16:06:12 +0100, Conor Dooley wrote: >>> On Fri, Aug 25, 2023 at 04:13:24PM +0800, William Qiu wrote: >>>> Hi, >>>> >>>> This patchset adds initial rudimentary support for the StarFive >>>> Pulse Width Modulation controller driver. And this driver will >>>> be used in StarFive's VisionFive 2 board.The first patch add >>>> Documentations for the device and Patch 2 adds device probe for >>>> the module. >>>> >>>> Changes v3->v4: >>>> - Rebased to v6.5rc7. >>>> - Sorted the header files in alphabetic order. >>>> - Changed iowrite32() to writel(). >>>> - Added a way to turn off. >>>> - Moified polarity inversion implementation. >>>> - Added 7100 support. >>>> - Added dts patches. >>>> - Used the various helpers in linux/math.h. >>>> - Corrected formatting problems. >>>> - Renamed dtbinding to 'starfive,jh7100-pwm.yaml'. >>>> - Dropped the redundant code. >>>> >>>> Changes v2->v3: >>>> - Fixed some formatting issues. >>>> >>>> Changes v1->v2: >>>> - Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'. >>>> - Dropped the compatible's Items. >>>> - Dropped the unuse defines. >>>> - Modified the code to follow the Linux coding style. >>>> - Changed return value to dev_err_probe. >>>> - Dropped the unnecessary local variable. >>>> >>>> The patch series is based on v6.5rc7. >>> >>> Out of curiosity, why is this series still an RFC? >> >> There was no comments received in v4. So William resend it and >> request for comments. > > The question was: why he requests for comments? > > RFC means *it should not be merged, it is not ready*. Oh, it was misunderstood by William and me. So this series is not a RFC. Best regards, Hal _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv