From: Song Shuai <suagrfillet@gmail.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: xianting.tian@linux.alibaba.com, mick@ics.forth.gr,
heinrich.schuchardt@canonical.com, guoren@kernel.org,
k-hagio-ab@nec.com, yixun.lan@gmail.com, lijiang@redhat.com,
linux-riscv@lists.infradead.org, kexec@lists.infradead.org,
crash-utility@redhat.com, alex@ghiti.fr
Subject: Re: [Crash-utility] RISCV64: Use va_kernel_pa_offset in VTOP()
Date: Mon, 24 Jul 2023 16:44:12 +0800 [thread overview]
Message-ID: <855df973-4f4b-6fff-a228-c1af80c14db0@gmail.com> (raw)
In-Reply-To: <20230724-sandpaper-raving-9ad883223e6d@wendy>
在 2023/7/24 15:41, Conor Dooley 写道:
> Hey,
>
> On Mon, Jul 24, 2023 at 12:06:49PM +0800, Song Shuai wrote:
>> Since RISC-V Linux v6.4, the commit 3335068f8721 ("riscv: Use
>> PUD/P4D/PGD pages for the linear mapping") changes the
>> phys_ram_base from the kernel_map.phys_addr to the start of DRAM.
>>
>> The Crash's VTOP() still uses phys_ram_base and kernel_map.virt_addr
>> to translate kernel virtual address, that made Crash boot failed with
>> Linux v6.4 and later version.
>>
>> Let Linux export kernel_map.va_kernel_pa_offset in v6.5 and Crash can
>> use "va_kernel_pa_offset" to translate the kernel virtual address in
>> VTOP() correctly.
>>
>> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
>> ---
>> You can check/test the Linux changes from this link:
>> https://github.com/sugarfillet/linux/commits/6.5-rc3-crash
>>
>> And I'll send the Linux changes to riscv/for-next If you're ok with this patch.
>
> If you want this to go into 6.5, you'll need to send it for riscv/fixes
> instead. It sounds like a fix for this would need to go into 6.4 too,
> no?
You're right, that should be riscv/fixes for 6.5 and this issue also
need to be fixed in 6.4 stable.
How about waiting for Crash guys' comments on the introduction of the
"va_kernel_pa_offset" in vmcoreinfo
and then determine which stable version should be taken in the first
"if" of kernel_version.
>
--
Thanks
Song Shuai
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-24 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 4:06 [Crash-utility] RISCV64: Use va_kernel_pa_offset in VTOP() Song Shuai
2023-07-24 7:41 ` Conor Dooley
2023-07-24 8:44 ` Song Shuai [this message]
2023-07-24 9:22 ` HAGIO KAZUHITO(萩尾 一仁)
2023-07-24 8:13 ` Alexandre Ghiti
2023-07-24 8:48 ` Song Shuai
2023-08-04 4:42 ` HAGIO KAZUHITO(萩尾 一仁)
2023-08-04 9:20 ` Song Shuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=855df973-4f4b-6fff-a228-c1af80c14db0@gmail.com \
--to=suagrfillet@gmail.com \
--cc=alex@ghiti.fr \
--cc=conor.dooley@microchip.com \
--cc=crash-utility@redhat.com \
--cc=guoren@kernel.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=xianting.tian@linux.alibaba.com \
--cc=yixun.lan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).