From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFFF8EB64D7 for ; Fri, 23 Jun 2023 12:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2GntphODYgAbar6ZrRo+bcoQKlwkwosRP8Qc7daVo2M=; b=u5tTd1g1/c0eLt /fBSR7jnW/J6AG3azPPmaIcXk+aKacZQDUKz4dOz/rLdcnJ2vqdqEN5HkG/boTtMz6ifrCRFxSZ4I j8mMWWCmLoDES36fRmwCwsyGz/nMbOsBODSghGmrt2Bzuh67rBD/ngbfjtCpuRSQeM/hKEDwoCl// pv0VIgr/JzzF+4Out0wHCktaD765ARhth1xzgim2vzOwUXuINqmF8tWcs7tdQT+DrDr8cCgh0Ii2O i7LJADYWxnkq1t0C/DT9kHeoOm4YLjx3nWJ0vI+xhWboydrsWeLm6+rOVSL3ajOOKQFP34Vzlm8KV YKP0upm2OOvQZgYcRYLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCgEd-003a5g-34; Fri, 23 Jun 2023 12:49:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCgEb-003a4n-0h for linux-riscv@lists.infradead.org; Fri, 23 Jun 2023 12:49:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC28D61A22; Fri, 23 Jun 2023 12:49:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3191BC433C0; Fri, 23 Jun 2023 12:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687524591; bh=9jQs0S7PGplotxU57o2pvvL0Cr/c4F03tmay59rArwI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j8Wqa0v9XlimtVUmIin2dvD0fnRgMA7b4U28B0NWLIDYi1qvR9Ktx3/8v1bgNf5Jh HXGZJIVO9MqsoeCUlVQBZWxz9SWcRaiySP/HwRetmN15uXQOb9Ky2YLq2OggS/c1Gi 1pO51CHvYn1hpFtK5Axn8lM8rsJlrINOm/fPDGowDJCoPORW0aDyoeIPo6yBrHYyJQ E+4jyW7yToQsA2gz8bEkPRf+MRoL9N/WHa2ClDP//nL1rltx+/wFc7V83nU9tF0ATe ZNtYzPE4oUmNiv/Q83eqM9P9SmtXG23njnA/JfHPq8lhd1sDQtJBy3wuE0+WLATwjb VYeKusnC6qG/Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qCgEW-007keF-Ga; Fri, 23 Jun 2023 13:49:48 +0100 Date: Fri, 23 Jun 2023 13:49:47 +0100 Message-ID: <86mt0qbaxg.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Saravana Kannan , Anup Patel , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Robin Murphy , Joerg Roedel , Will Deacon , Frank Rowand , Atish Patra , Andrew Jones , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev, Android Kernel Team Subject: Re: [PATCH v4 08/10] irqchip: Add RISC-V advanced PLIC driver In-Reply-To: References: <20230613153415.350528-1-apatel@ventanamicro.com> <20230613153415.350528-9-apatel@ventanamicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: apatel@ventanamicro.com, saravanak@google.com, anup@brainfault.org, palmer@dabbelt.com, paul.walmsley@sifive.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, frowand.list@gmail.com, atishp@atishpatra.org, ajones@ventanamicro.com, conor@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_054953_360958_D22976EE X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org [here, let me trim all of this nonsense...] On Fri, 23 Jun 2023 12:47:00 +0100, Anup Patel wrote: > > No. My previous email asking you to NOT use IRQCHIP_DECLARE() and > > instead use IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros. > > I tried IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros but these > macros are not suitable for APLIC driver because we need platform device > pointer in the APLIC probe() to create platform MSI device domain (refer, > platform_msi_create_device_domain()). Oh come on. How hard have you tried? Have you even looked at the other drivers in the tree to see how they solve this insurmountable problem with a *single* line of code? pdev = of_find_device_by_node(node); That's it. > Further, I tried setting the "suppress_bind_attrs" flag in "struct > platform_driver aplic_driver" just like the > IRQCHIP_PLATFORM_DRIVER_END() macro but this did not work. I'm not sure how relevant this is to the conversation. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv