Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE_IMS

From: Marc Zyngier <maz@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>
Cc: devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
	"Saravana Kannan" <saravanak@google.com>,
	"Anup Patel" <anup@brainfault.org>,
	"Atish Patra" <atishp@atishpatra.org>,
	linux-kernel@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Frank Rowand" <frowand.list@gmail.com>,
	linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	"Andrew Jones" <ajones@ventanamicro.com>
Subject: Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE_IMS
Date: Thu, 15 Feb 2024 11:54:11 +0000	[thread overview]
Message-ID: <86o7ci3puk.wl-maz@kernel.org> (raw)
In-Reply-To: <20240127161753.114685-5-apatel@ventanamicro.com>

On Sat, 27 Jan 2024 16:17:32 +0000,
Anup Patel <apatel@ventanamicro.com> wrote:
> 
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Add a new domain bus token to prepare for device MSI which aims to replace
> the existing platform MSI maze.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  include/linux/irqdomain_defs.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_defs.h
> index c29921fd8cd1..4c69151cb9d2 100644
> --- a/include/linux/irqdomain_defs.h
> +++ b/include/linux/irqdomain_defs.h
> @@ -26,6 +26,7 @@ enum irq_domain_bus_token {
>  	DOMAIN_BUS_DMAR,
>  	DOMAIN_BUS_AMDVI,
>  	DOMAIN_BUS_PCI_DEVICE_IMS,
> +	DOMAIN_BUS_DEVICE_IMS,

Only a personal taste, but since we keep calling it "device MSI",
which it really is, I find it slightly odd to name the token
"DEVICE_IMS".

From what I understand, IMS is PCIe specific. Platform (and by
extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI
would make a lot more sense and avoid confusion.

But hey, I don't have much skin in this game, and I can probably
mentally rotate the acronym...

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv