From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B27DC4332F for ; Thu, 17 Nov 2022 19:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=atpsq+mTmQE3TzxfoVv2U3QPfIWrkSThFx7c6gw5oB0=; b=VTnTR8e4BYKG1j 6gF0AgjA2Oa3IAnolHAXQ1WY8AFYi4JRCzvJSJyoYr68mVYACVwVGipTieO25MPHSlg6QpP1EPOx8 kUZGXUwvUWQECa1MCx9NwBGYXCsMIraJ1iJqUp183dwew0NZdzLBwSo9k9c8mUVhQeiNatwjlJdmH bTZoenrfzKsZPt9pp06MZ30h1VIIoUbs7DFUvkzkp5vC7rIKWctI3KNKHyEp5f1HiVGuvRvzauIhr flgADb25LvuosU2S4K22Y1KSaadcS385hW0hbcBpuWRvfpMsQKtsilQr0mO1ImyAV0cWJ1KPk8nGI jfHEkEpDUtxTFE2184Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovkh7-00H0QH-3r; Thu, 17 Nov 2022 19:37:05 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovkh3-00H0PC-Tq for linux-riscv@lists.infradead.org; Thu, 17 Nov 2022 19:37:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6202A62228; Thu, 17 Nov 2022 19:37:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3078C433C1; Thu, 17 Nov 2022 19:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668713820; bh=YCFOtk7JBzhIwUsv4FanZcQX+MYSaTlook2QWHvkNa4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jCKgellvHA8N2E2PGeI3BG0qtk6wUz5JkaSbIK9ZtXDR4rRcdzjUJGICxTD6ph7PW Gq01NGyvIEd2CfqlDG21VbU7v/3f0q+4KPEVsYUUgjCtfyw0fzYKmknL0WD5cYk1Py 71wIn2Dp/4Y9B9RgLcR9qv2abT/2c7axs1XTPPe5vgNAFFgdr5sDDLzKIUkeTce2cN udMqvzekf6imAXhEXgPJx2pBrKRoolbRF5wjcEim7e4SIQ0RsYvHJxkX2zNSRb4UtY uD7rlCsr+5Flb2WXP/nvwZglm2BvOmI9IUjy0WYDKjggiYxNRztQl1xDLBX+ReIk1L uTpxg88mw3PoQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovkh0-006opa-9Q; Thu, 17 Nov 2022 19:36:58 +0000 Date: Thu, 17 Nov 2022 19:36:57 +0000 Message-ID: <86y1s9nzja.wl-maz@kernel.org> From: Marc Zyngier To: Conor Dooley Cc: Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Conor Dooley Subject: Re: [PATCH] irqchip/sifive-plic: default to enabled In-Reply-To: <20221117185942.3896559-1-conor@kernel.org> References: <20221117185942.3896559-1-conor@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: conor@kernel.org, tglx@linutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, conor.dooley@microchip.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_113702_067214_89AC22B6 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, 17 Nov 2022 18:59:43 +0000, Conor Dooley wrote: > > From: Conor Dooley > > The SiFive PLIC driver is used by all current implementations, including > those that do not have a SiFive PLIC. Default the driver to enabled, > with the intention of later removing the current "every SOC selects > this" situation in Kconfig.socs at the moment. > > The speculative "potential others" in the description no longer makes > any sense, as the driver is always used. Update the Kconfig symbol's > description to reflect the driver's ubiquitous state. > > Signed-off-by: Conor Dooley > --- > Hey Marc, > > I recall some discussion when this driver was extended to other PLICs a > few months ago: > https://lore.kernel.org/linux-riscv/20511a05f39408c8ffbcc98923c4abd2@kernel.org/ > > Perhaps I got the wrong impression, but it seemed to me that you intend > for future implementations to reuse this driver where possible? Well, within reasons. People seem to have some very liberal interpretations of the architecture spec... > > I'd like to think, and surely will be proven wrong, that ~all future > plic implementations should be similar enough to fit that bill. > It's kinda on this basis that I figure switching this thing to default y > should be okay. It's already only buildable on RISC-V & every > implementation uses it, so no difference there. If you expect this to be present at all times, why isn't this selected by the architecture Kconfig instead? I always find it pretty odd to have something that is 'default y' and yet constrained by a 'depend MYARCH'. A 'select PLIC' would make a lot more sense. And then you can stop making this user selectable. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv