From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F12C3606A31A for ; Fri, 23 Oct 2026 13:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=C5xhMhTi; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=m7RG/5lG DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=UYQOnvogJLxbHE1BQ2YLUCRyMxHTrwvWCT5ZLEhrwoo=; b=C5xhMhTiR9wE43nNxjMkSxJzK5 Li1uMCAPJP6Fn56dDpkxfCVYDfYumFLfql96/pA7hiPfNLzj7KNQGsZirucv/N0xnux1qKA5pQoo+ Bt0e2D4mAxsrHlNt1COSsuoXx+JTDUBMb4YXFyFomJPtImN7rlVMddgS4EqnJN//Rb8yt8MzfHu8x pvDHTaZLtOVb/m5tKqRUzZOkIsNe77OWV8H+J0y4jkOrb7Df0/+RVMSCRU5ZVadw3O7blS9BsphzP SiowRpHWEm8i1YS08orXqXV71MOqPWsdziA+rvHOXKkWHsau15u+IyG8Ag0nwPbJ7Yxliho7hSZD+ i3VBZa9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKF1G-0000000GLgg-1Wea; Fri, 23 Oct 2026 13:09:14 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKF1E-0000000GLgR-0alb; Fri, 23 Oct 2026 13:09:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BCED242AF7; Fri, 23 Oct 2026 13:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEFE51F01825; Fri, 23 Oct 2026 13:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792760950; bh=nlznPFw9V2Gc6GAfgQKy3QilQuYPxjyao4Hf2pcvcDM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=m7RG/5lGWSbIc838b0jmvSS290uWfurhu3YNfo5bVNzSTvTPTC7ghSWC8leVP3nQ+ b1I3jDHg/InxLf552w5eGHsTrs/J6pcIRU/3j2o4lXMu8kdY2pE31lXQZ6mDuOD9a9 /bZSvE9+INNA1eyAemAPUHtpahZxa52CO1uiN/pTg/xq6n5EpQE55LyKwMgvscOovl vpke1gUvPTZai31N3aWvQD3q3fnksvGf8uxqyvKnNdAccPdM5DjsmOgJhH0dNQrOqX DgjQebBUKnbd01GrrL7MPL69Sel1P4/LLNB/kJOWZzm+JYUNtbLukoPTq27kTGyxJT /kgHrVGsqnwng== From: Thomas Gleixner To: "H. Peter Anvin" , Sebastian Andrzej Siewior Cc: LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Michal =?utf-8?Q?Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 16/18] x86/entry: Get rid of the sys_ni_syscall() indirection In-Reply-To: <1149A39E-BEBA-46EA-94F4-4DFFC4733EF5@zytor.com> References: <20260707181957.433213175@kernel.org> <20260707190254.493733289@kernel.org> <20261022142425.3Wx-RrU5@linutronix.de> <87fqxx1r80.ffs@fw13> <87cxt11ktr.ffs@fw13> <1149A39E-BEBA-46EA-94F4-4DFFC4733EF5@zytor.com> Date: Fri, 23 Oct 2026 15:09:07 +0200 Message-ID: <871p9g1s3w.ffs@fw13> X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Oct 22 2026 at 17:22, H. Peter Anvin wrote: > On October 22, 2026 2:34:08 PM PDT, Thomas Gleixner wrote: >>-static __always_inline void do_syscall_x32(struct pt_regs *regs, unsigned long nr) >>+static __always_inline bool do_syscall_x32(struct pt_regs *regs, unsigned long nr) >> { >>+ if (!IS_ENABLED(CONFIG_X86_X32_ABI)) >>+ return false; >>+ >>+ /* Preserve the historic insanity of treating -1 special on x32 */ >>+ if (nr == ULONG_MAX) >>+ return true; > > It was never limited to x32... Tired brain misread the test output: [RUN] Running tests under ptrace: modifying the default return [RUN] Checking system calls with msb = 0 (0x0) [OK] x32 syscalls 0:-64..-2 returned -ENOSYS as expected [OK] x32 syscall 0:-1 returned MODIFIED_BY_PTRACE as expected [OK] x64 syscalls 0:-64..-1 returned -ENOSYS as expected But that's because the "-1" on x32 is actually 0xFFFFFFFF while on x64 it's 0x7FFFFFFF. The whole mess comes from using -1 as indicator for syscall abort which is undistinguishable from a syscall(nr=-1). Bah. Let me restore this nonsense. Thanks, tglx _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv