From: Thomas Gleixner <tglx@kernel.org>
To: Haofeng Li <920484857@qq.com>
Cc: Haofeng Li <13266079573@163.com>, Haibo Xu <haibo1.xu@intel.com>,
Anup Patel <anup@brainfault.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel.holland@sifive.com>,
Paul Walmsley <pjw@kernel.org>, Haofeng Li <lihaofeng@kylinos.cn>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 03/16] irqchip/sifive-plic: do not iounmap devm mappings
Date: Thu, 20 Aug 2026 08:36:06 +0200 [thread overview]
Message-ID: <874igpjo2x.ffs@fw13> (raw)
In-Reply-To: <tencent_A781C26C35482A03F6BD42B277ED977B8F08@qq.com>
On Tue, Jul 14 2026 at 21:24, Haofeng Li wrote:
> - iounmap(regs);
> + /* Only OF path uses of_iomap(); ACPI/platform uses devm mapping. */
Instead of this comment and conditional unmap the OF specific map side
should just use devm_of_iomap(), no?
> + if (is_of_node(fwnode))
> + iounmap(regs);
> return error;
> }
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-08-20 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:23 [PATCH 00/16] irqchip: harden initialization error paths Haofeng Li
2026-07-14 12:23 ` [PATCH 01/16] irqchip/riscv-imsic: fix MMIO lookup OOB and NULL cleanup Haofeng Li
2026-07-14 13:15 ` Anup Patel
2026-07-25 16:13 ` Radu Rendec
2026-07-14 13:24 ` [PATCH 03/16] irqchip/sifive-plic: do not iounmap devm mappings Haofeng Li
2026-07-14 15:05 ` Anup Patel
2026-08-20 6:36 ` Thomas Gleixner [this message]
2026-07-25 16:29 ` [PATCH 00/16] irqchip: harden initialization error paths Radu Rendec
2026-08-20 7:49 ` Thomas Gleixner
2026-09-05 4:11 ` Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874igpjo2x.ffs@fw13 \
--to=tglx@kernel.org \
--cc=13266079573@163.com \
--cc=920484857@qq.com \
--cc=anup@brainfault.org \
--cc=haibo1.xu@intel.com \
--cc=lihaofeng@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pjw@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox