From: "Björn Töpel" <bjorn@kernel.org>
To: Evgenii Shatokhin <e.shatokhin@yadro.com>,
Andy Chiu <andybnac@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Nathan Chancellor <nathan@kernel.org>,
Justin Stitt <justinstitt@google.com>,
Bill Wendling <morbo@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
llvm@lists.linux.dev, bjorn@rivosinc.com, puranjay12@gmail.com,
alexghiti@rivosinc.com, yongxuan.wang@sifive.com,
greentime.hu@sifive.com, nick.hu@sifive.com,
nylon.chen@sifive.com, tommy.wu@sifive.com, eric.lin@sifive.com,
viccent.chen@sifive.com, zong.li@sifive.com,
samuel.holland@sifive.com
Subject: Re: [PATCH v3 0/7] riscv: ftrace: atmoic patching and preempt improvements
Date: Fri, 06 Dec 2024 09:39:23 +0100 [thread overview]
Message-ID: <87a5d9gq84.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <990b942d-fe91-4bda-a38e-1eb47f2f6086@yadro.com>
Evgenii Shatokhin <e.shatokhin@yadro.com> writes:
> On 03.12.2024 15:18, Björn Töpel wrote:
>> Andy!
>>
>> "atomic" spelling in the Subject line.
>>
>> Andy Chiu <andybnac@gmail.com> writes:
>>
>>> Changes in v3:
>>> - Add a fix tag for patch 1
>>> - Add a data fence before sending out remote fence.i (6)
>>> - Link to v2: https://lore.kernel.org/all/20240628-dev-andyc-dyn-ftrace-v4-v2-0-1e5f4cb1f049@sifive.com/
>>
>> Hmm, the fixes tag was not included.
>>
>> Also, there was a lot of comments from v2 that was not addressed:
>>
>> * Minor spelling nits
>> * Breaking DIRECT_CALL, and include Puranjay's CALL_OPS work in the
>> same series for DIRECT_CALL, to avoid breakage.
>
> Yes, FTRACE_WITH_DIRECT_CALLS is currently broken. If I try to insmod
> samples/ftrace/ftrace-direct.ko, it reports a failure:
>
>
> [ 179.531472] ------------[ ftrace bug ]------------
> [ 179.531761] ftrace failed to modify
> [ 179.531786] [<ffffffff8005f9ac>] wake_up_process+0x0/0x24
> [ 179.532577] actual: 97:e2:fa:ff:13:00:00:00
> [ 179.533211] Setting ftrace call site to call ftrace function
> [ 179.534409] ftrace record flags: 99980001
> [ 179.534692] (1) tramp: ftrace_caller+0x0/0x34
> (call_direct_funcs+0x0/0x14)
> [ 179.534692] expected tramp: ffffffff01b0d000
> ...
And just a regular Ubuntu 24.10 will fail with all subsystems using BPF
trampoline, e.g.
------------[ ftrace bug ]------------
ftrace failed to modify
[<ffffffff80250d98>] bpf_lsm_file_open+0x0/0x1c
CALL_OPS with definitely a must for this series.
Björn
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-12-06 8:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 17:29 [PATCH v3 0/7] riscv: ftrace: atmoic patching and preempt improvements Andy Chiu
2024-11-27 17:29 ` [PATCH v3 1/7] riscv: ftrace: support fastcc in Clang for WITH_ARGS Andy Chiu
2024-12-03 12:05 ` Björn Töpel
2024-12-03 14:44 ` Evgenii Shatokhin
2024-11-27 17:29 ` [PATCH v3 2/7] riscv: ftrace: align patchable functions to 4 Byte boundary Andy Chiu
2024-11-27 17:29 ` [PATCH v3 3/7] riscv: ftrace: prepare ftrace for atomic code patching Andy Chiu
2024-12-01 15:31 ` Evgenii Shatokhin
2024-12-02 7:29 ` Evgenii Shatokhin
2024-12-06 10:02 ` Björn Töpel
2024-12-06 23:35 ` Bagas Sanjaya
2024-12-09 14:57 ` Robbin Ehn
2024-11-27 17:29 ` [PATCH v3 4/7] riscv: ftrace: do not use stop_machine to update code Andy Chiu
2024-11-27 17:29 ` [PATCH v3 5/7] riscv: vector: Support calling schedule() for preemptible Vector Andy Chiu
2024-11-27 17:29 ` [PATCH v3 6/7] riscv: add a data fence for CMODX in the kernel mode Andy Chiu
2025-03-10 19:08 ` Björn Töpel
2025-03-11 12:44 ` Andrea Parri
2025-03-11 14:53 ` Björn Töpel
2025-03-11 18:11 ` Andrea Parri
2025-03-13 18:12 ` Andy Chiu
2025-03-14 15:23 ` Andrea Parri
2024-11-27 17:29 ` [PATCH v3 7/7] riscv: ftrace: support PREEMPT Andy Chiu
2025-03-10 19:09 ` Björn Töpel
2024-11-27 21:25 ` [PATCH v3 0/7] riscv: ftrace: atmoic patching and preempt improvements Björn Töpel
2024-12-24 3:15 ` Steven Rostedt
2024-12-29 19:08 ` Andy Chiu
2025-01-06 15:22 ` Andy Chiu
2024-12-02 7:58 ` Evgenii Shatokhin
2024-12-11 15:38 ` Andy Chiu
2024-12-03 12:18 ` Björn Töpel
2024-12-03 15:09 ` Evgenii Shatokhin
2024-12-06 8:39 ` Björn Töpel [this message]
2024-12-11 15:48 ` Andy Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5d9gq84.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=alexghiti@rivosinc.com \
--cc=andybnac@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn@rivosinc.com \
--cc=e.shatokhin@yadro.com \
--cc=eric.lin@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nick.hu@sifive.com \
--cc=nylon.chen@sifive.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=puranjay12@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=tommy.wu@sifive.com \
--cc=viccent.chen@sifive.com \
--cc=yongxuan.wang@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox