Re: [RFC PATCH 08/15] iommu/riscv: Add IRQ domain for interrupt remapping

Jason Gunthorpe
2024-11-19T14:01:00Z

On Tue, Nov 19, 2024 at 08:49:37AM +0100, Andrew Jones wrote:
> On Mon, Nov 18, 2024 at 02:43:36PM -0400, Jason Gunthorpe wrote:
> > On Thu, Nov 14, 2024 at 05:18:53PM +0100, Andrew Jones wrote:
> > > @@ -1276,10 +1279,30 @@ static int riscv_iommu_attach_paging_domain(struct iommu_domain *iommu_domain,
> > > struct riscv_iommu_device *iommu = dev_to_iommu(dev);
> > > struct riscv_iommu_info *info = dev_iommu_priv_get(dev);
> > > struct riscv_iommu_dc dc = {0};
> > > + int ret;
> > >
> > > if (!riscv_iommu_pt_supported(iommu, domain->pgd_mode))
> > > return -ENODEV;
> > >
> > > + if (riscv_iommu_bond_link(domain, dev))
> > > + return -ENOMEM;
> > > +
> > > + if (iommu_domain->type == IOMMU_DOMAIN_UNMANAGED) {
> >
> > Drivers should not be making tests like this.
> >
> > > + domain->gscid = ida_alloc_range(&riscv_iommu_gscids, 1,
> > > + RISCV_IOMMU_MAX_GSCID, GFP_KERNEL);
> > > + if (domain->gscid < 0) {
> > > + riscv_iommu_bond_unlink(domain, dev);
> > > + return -ENOMEM;
> > > + }
> > > +
> > > + ret = riscv_iommu_irq_domain_create(domain, dev);
> > > + if (ret) {
> > > + riscv_iommu_bond_unlink(domain, dev);
> > > + ida_free(&riscv_iommu_gscids, domain->gscid);
> > > + return ret;
> > > + }
> > > + }
> >
> > What are you trying to do? Make something behave different for VFIO?
> > That isn't OK, we are trying to remove all the hacky VFIO special
> > cases in drivers.
> >
> > What is the HW issue here? It is very very strange (and probably not
> > going to work right) that the irq domains change when domain
> > attachment changes.
> >
> > The IRQ setup should really be fixed before any device drivers probe
> > onto the device.
>
> I can't disagree with the statement that this looks hacky, but considering
> a VFIO domain needs to use the g-stage for its single-stage translation
> and a paging domain for the host would use s-stage, then it seems we need
> to identify the VFIO domains for their special treatment.

This is the wrong thinking entirely. There is no such thing as a "VFIO
domain".

Default VFIO created domains should act excatly the same as a DMA API
domain.

If you want your system to have irq remapping, then it should be on by
default and DMA API gets remapping too. There would need to be a very
strong reason not to do that in order to make something special for
riscv. If so you'd need to add some kind of flag to select it.

Until you reach nested translation there is no "need" for VFIO to use
any particular stage. The design is that default VFIO uses the same
stage as the DMA API because it is doing the same basic default
translation function.

Nested translation has a control to select the stage, and you can
then force the g-stage for VFIO users at that point.

Regardless, you must not use UNMANAGED as some indication of VFIO,
that is not what it means, that is not what it is for.

> Is there an example of converting VFIO special casing in other
> drivers to something cleaner that you can point me at?

Nobody has had an issue where they want interrupt remapping on/off
depending on VFIO. I think that is inherently wrong.

> The IRQ domain will only be useful for device assignment, as that's when
> an MSI translation will be needed. I can't think of any problems that
> could arise from only creating the IRQ domain when probing assigned
> devices, but I could certainly be missing something. Do you have some
> potential problems in mind?

I'm not an expert in the interrupt subsystem, but my understanding was
we expect the interrupt domains/etc to be static once a device driver
is probed. Changing things during iommu domain attach is after drivers
are probed. I don't really expect it to work correctly in all corner
cases.

VFIO is allowed to change the translation as it operates and we expect
that interrupts are not disturbed.

Jason