public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Samuel Holland <samuel.holland@sifive.com>
Subject: Re: [PATCH 3/7] riscv: kprobes: Use patch_text_nosync() for insn slots
Date: Mon, 19 Feb 2024 13:52:27 +0100	[thread overview]
Message-ID: <87a5nwfwfo.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <20240212025529.1971876-4-samuel.holland@sifive.com>

Samuel Holland <samuel.holland@sifive.com> writes:

> These instructions are not yet visible to the rest of the system,
> so there is no need to do the whole stop_machine() dance.
>
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
>  arch/riscv/kernel/probes/kprobes.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c
> index 2f08c14a933d..cbf8197072bf 100644
> --- a/arch/riscv/kernel/probes/kprobes.c
> +++ b/arch/riscv/kernel/probes/kprobes.c
> @@ -28,9 +28,9 @@ static void __kprobes arch_prepare_ss_slot(struct kprobe *p)
>  
>  	p->ainsn.api.restore = (unsigned long)p->addr + offset;
>  
> -	patch_text(p->ainsn.api.insn, &p->opcode, 1);
> -	patch_text((void *)((unsigned long)(p->ainsn.api.insn) + offset),
> -		   &insn, 1);
> +	patch_text_nosync(p->ainsn.api.insn, &p->opcode, 1);
> +	patch_text_nosync(p->ainsn.api.insn + offset,
> +			  &insn, 1);

Nit: 100 chars lines!

Nice find!

Reviewed-by: Björn Töpel <bjorn@rivosinc.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-02-19 12:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  2:55 [PATCH 0/7] riscv: Various text patching improvements Samuel Holland
2024-02-12  2:55 ` [PATCH 1/7] riscv: jump_label: Batch icache maintenance Samuel Holland
2024-02-19 12:27   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 2/7] riscv: jump_label: Simplify assembly syntax Samuel Holland
2024-02-19 12:27   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 3/7] riscv: kprobes: Use patch_text_nosync() for insn slots Samuel Holland
2024-02-19 12:52   ` Björn Töpel [this message]
2024-02-12  2:55 ` [PATCH 4/7] riscv: Simplify text patching loops Samuel Holland
2024-02-19 13:03   ` Björn Töpel
2024-02-19 22:13     ` David Laight
2024-03-27 15:12       ` Samuel Holland
2024-03-27 15:11     ` Samuel Holland
2024-02-12  2:55 ` [PATCH 5/7] riscv: Pass patch_text() the length in bytes Samuel Holland
2024-02-19 13:04   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 6/7] riscv: Use offset_in_page() in text patching functions Samuel Holland
2024-02-19 13:07   ` Björn Töpel
2024-02-12  2:55 ` [PATCH 7/7] riscv: Remove extra variable in patch_text_nosync() Samuel Holland
2024-02-19 13:08   ` Björn Töpel
2024-02-13 12:58 ` [PATCH 0/7] riscv: Various text patching improvements Andrea Parri
2024-02-19 12:25   ` Björn Töpel
2024-02-20 22:11     ` Alexandre Ghiti
2024-03-27 15:32   ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5nwfwfo.fsf@all.your.base.are.belong.to.us \
    --to=bjorn@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=samuel.holland@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox