From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29111C4338F for ; Mon, 26 Jul 2021 13:45:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE03560F42 for ; Mon, 26 Jul 2021 13:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE03560F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q8oAXyKIaL4kvS0Guvz6irkELKlZm/4ux7lN4fQOwNo=; b=1IgHdm9LfE5gP1 h3bjWnlAWnXWkvvjhZNvRMD5GdoTtjzyRf394y6P2NKoon7MZqOqzohFigyZJrHKavttTazIg7RoV PyGl63XQR5BHJiQNULHQLNx4iTbHl220wSc4tWYlNOol0NrjQAz0iKeSz66vBJXTt+zqAj+EIPgPl TshrYeEyNWl3QFcz++1K8BZ8nBLiaT4y9E6YR65pAW+CMkx15kZZ9E8cx+uNUXjr1a3OGpvrHSZI9 ZPx4RXD/UcnKvoCagKQ/9cdJNCUDSrvo/UBPuTKZ8cWcmph+eJWJA67KXYxbVDKsrrpZtmN4JHdff 3C9fmMuWm8jzLgPkjK2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m80uj-00BMf7-Fc; Mon, 26 Jul 2021 13:45:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m80uh-00BMeK-KL for linux-riscv@lists.infradead.org; Mon, 26 Jul 2021 13:45:00 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B59560F42; Mon, 26 Jul 2021 13:44:59 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m80uf-0013G7-7A; Mon, 26 Jul 2021 14:44:57 +0100 Date: Mon, 26 Jul 2021 14:44:56 +0100 Message-ID: <87lf5tdw9z.wl-maz@kernel.org> From: Marc Zyngier To: Anup Patel Cc: Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Daniel Lezcano , Rob Herring , Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bin Meng Subject: Re: [RFC PATCH v2 02/11] RISC-V: Use common print prefix in smp.c In-Reply-To: <20210618123851.1344518-3-anup.patel@wdc.com> References: <20210618123851.1344518-1-anup.patel@wdc.com> <20210618123851.1344518-3-anup.patel@wdc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anup.patel@wdc.com, palmer@dabbelt.com, palmerdabbelt@google.com, paul.walmsley@sifive.com, tglx@linutronix.de, daniel.lezcano@linaro.org, robh+dt@kernel.org, atish.patra@wdc.com, Alistair.Francis@wdc.com, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bmeng.cn@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_064459_746459_1134ACCE X-CRM114-Status: GOOD ( 21.64 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, 18 Jun 2021 13:38:42 +0100, Anup Patel wrote: > > We add "#define pr_fmt()" in smp.c to use "riscv:" as common > print prefix for all pr_xyz() statements in this file. > > Signed-off-by: Anup Patel > Reviewed-by: Bin Meng > --- > arch/riscv/kernel/smp.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c > index 547dc508f7d1..eea0c9d11d9f 100644 > --- a/arch/riscv/kernel/smp.c > +++ b/arch/riscv/kernel/smp.c > @@ -8,6 +8,7 @@ > * Copyright (C) 2017 SiFive > */ > > +#define pr_fmt(fmt) "riscv: " fmt > #include > #include > #include > @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(mask); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); > } > > static void send_ipi_single(int cpu, enum ipi_message_type op) > @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(cpumask_of(cpu)); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); "SMP:" made a lot more sense. I assume that the user knows that they are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix for a message indicates the provenance of the message. I honestly don't see the point in this change. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv