From: "Björn Töpel" <bjorn@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Tejun Heo" <tj@kernel.org>, "David Vernet" <void@manifault.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Björn Töpel" <bjorn@rivosinc.com>,
bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
"Anders Roxell" <anders.roxell@linaro.org>
Subject: Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target
Date: Mon, 07 Oct 2024 18:45:32 +0200 [thread overview]
Message-ID: <87msjfn9oz.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <ZwQKRe7iIzZjjEQd@finisterre.sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
> On Mon, Oct 07, 2024 at 06:00:57PM +0200, Björn Töpel wrote:
>> Mark Brown <broonie@kernel.org> writes:
>> > On Mon, Oct 07, 2024 at 09:31:32AM +0200, Björn Töpel wrote:
>
>> > CLNG-BPF create_dsq.bpf.o
>> > In file included from create_dsq.bpf.c:9:
>> > /home/broonie/git/linux/tools/sched_ext/include/scx/common.bpf.h:33:17: error: use of undeclared identifier 'SCX_DSQ_FLAG_BUILTIN'
>> > 33 | _Static_assert(SCX_DSQ_FLAG_BUILTIN,
>> > | ^
>
>> This is most likely due to incorrect VMLINUX_BTF_PATHS, so that
>> vmlinux.h is incorrectly generated. Try grepping for
>> SCX_DSQ_FLAG_BUILTIN in vmlinux.h.
>
> Yeah, it's not in the generated files:
>
> broonie@finisterre:~/git/linux$ grep SCX_DSQ_FLAG_BUILTIN ./tools/testing/selftests/sched_ext/build/include/vmlinux.h ./tools/testing/selftests/sched_ext/build/obj/bpftool/vmlinux.h
> broonie@finisterre:~/git/linux$
>
> I didn't actually build a kernel, if the build system needs a kernel
> it's just silently not detected that it's missing?
It tries to find a kernel with BTF:
| VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux) \
| $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux) \
| ../../../../vmlinux \
| /sys/kernel/btf/vmlinux \
| /boot/vmlinux-$(shell uname -r)
Similar to all the other selftests using BPF.
(Oh, and at some point the BPF parts should be in lib.mk...)
Björn
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-10-07 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 7:31 [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target Björn Töpel
2024-10-07 15:43 ` Mark Brown
2024-10-07 16:00 ` Björn Töpel
2024-10-07 16:20 ` Mark Brown
2024-10-07 16:45 ` Björn Töpel [this message]
2024-10-07 19:37 ` Mark Brown
2024-10-07 16:27 ` Mark Brown
2024-10-07 20:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msjfn9oz.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox