From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6F06C433EF for ; Sun, 30 Jan 2022 15:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B9qXTnzy0kddu5PJkAv8EjUGnsPmw8FnY1aGzi7b74k=; b=ROZDN+FhM11cgc ABKyh4LtnPa3dI0v5t/nW0vyv6ZofrD9HJsVAXsrTqVU61Qz2hOhbP5x8MBptsM+NiLS0Rppg24hb 6SPdmRGQ3gW/39+VfpvWxGCWChvVUL1CY5N9y4Pq1hxqN7++JXR5tF3vLTK3WhZJviHaCqmOVHo2T +Q4+tj5z7Af9Gy7lovHMwWqMupb1876WE6BoAlHmYdx8imZ+mITgI72P+BWF3fqBXWbBW6L8XMTYu yhwXx4YG6p/Mil7LCwgA6eieSgoaU85LYDFVXK4pc1/jQsYzOlOTrWulso+sdPKByg9yzjd8ZO10w Y3Cr0sudJe9FiDVpuYcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEBhu-006oDE-33; Sun, 30 Jan 2022 15:01:34 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEBfi-006n9z-Qk for linux-riscv@lists.infradead.org; Sun, 30 Jan 2022 14:59:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3FC60B80ADA; Sun, 30 Jan 2022 14:59:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D82C340E4; Sun, 30 Jan 2022 14:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643554756; bh=W6hUYxXfpCmTkoC0wP2SzdldEImzpCHUF1VB5w/7jH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GGo6dWALPKTmqwzp/Lti7mY+KzjFixmMjN4KuKwfTYOYYCr3obhINSaRVSRTwBvCf tH6rPniTrgzfxS5M6Q/JxrATzimluByc+mVaezwD7OpqcUN2Z9X/G/Y73dwS2xSUIk vRGwhnCPP3YNEYQZ94kQJkM7PmCXirpDrSaAqgz+fKabuAWeIo/7MEVsjzFYWU/BbZ HmA9V18/seI6F0JjbWckq3Bsm26A+4XFBnBCxzts8f1xZPWQxMrZL9a+J8uViZ0kVp LwoLDx0mVigHW3XHbqGVMG++4Nng9Ljv812gscNC2A9LWnbuIaEWAhJhnoJnvQ3qWo nG0uQmwfXjVjw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEBfd-004Ak7-Tv; Sun, 30 Jan 2022 14:59:14 +0000 Date: Sun, 30 Jan 2022 14:59:13 +0000 Message-ID: <87mtjdxoam.wl-maz@kernel.org> From: Marc Zyngier To: Guo Ren Cc: Samuel Holland , Anup Patel , Thomas Gleixner , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv , devicetree , Guo Ren Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic dt parse in opensbi In-Reply-To: References: <20220129162726.1154501-1-guoren@kernel.org> <20220129162726.1154501-3-guoren@kernel.org> <87r18qxui9.wl-maz@kernel.org> <35b1838d-ef80-1816-46f6-9cba7afc813e@sholland.org> <87o83ty0ti.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: guoren@kernel.org, samuel@sholland.org, anup@brainfault.org, tglx@linutronix.de, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, guoren@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220130_065919_046471_F0ED87B7 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, 30 Jan 2022 13:09:21 +0000, Guo Ren wrote: > > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier wrote: > > > > On Sun, 30 Jan 2022 04:39:34 +0000, > > Guo Ren wrote: > > > > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > > > I think we should give clear info in /proc/interrupts. I hope we could > > > keep thead_plic_init. > > > > Why? There is no material difference at the driver level, and > > /proc/interrupts won't be the target of a branding exercise (which > > this series seems to be all about). > It's not a branding exercise, the series just correct the broken code > & incorrect /proc/interrupts display. There is *nothing* incorrect in /proc/interrupt. If anything, changing the string *is* an ABI change, for no good reason. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv