From: <Valentina.FernandezAlanis@microchip.com>
To: <ziyao@disroot.org>, <Conor.Dooley@microchip.com>,
<Daire.McNamara@microchip.com>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<aou@eecs.berkeley.edu>, <alex@ghiti.fr>
Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<Valentina.FernandezAlanis@microchip.com>
Subject: Re: [PATCH v2 5/5] riscv: dts: microchip: add a device tree for Discovery Kit
Date: Wed, 3 Sep 2025 09:43:46 +0000 [thread overview]
Message-ID: <8b371196-c853-4e47-980f-3f2b3525180e@microchip.com> (raw)
In-Reply-To: <aLarlSG9tDA-1YiL@pie>
On 02/09/2025 09:32, Yao Zi wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Tue, Sep 02, 2025 at 08:55:48AM +0100, Valentina Fernandez wrote:
>> Add a minimal device tree for the Microchip PolarFire SoC Discovery Kit.
>> The Discovery Kit is a cost-optimized board based on PolarFire SoC
>> MPFS095T and features:
>>
>> - 1 GB DDR4x16
>> - 1x Gigabit Ethernet
>> - 3x UARTs
>> - Raspberry Pi connector
>> - mikroBus connector
>> - microSD card connector
>>
>> Link: https://www.microchip.com/en-us/development-tool/mpfs-disco-kit
>> Signed-off-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
>> ---
>> arch/riscv/boot/dts/microchip/Makefile | 1 +
>> .../dts/microchip/mpfs-disco-kit-fabric.dtsi | 58 ++++++
>> .../boot/dts/microchip/mpfs-disco-kit.dts | 190 ++++++++++++++++++
>> 3 files changed, 249 insertions(+)
>> create mode 100644 arch/riscv/boot/dts/microchip/mpfs-disco-kit-fabric.dtsi
>> create mode 100644 arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
>
> ...
>
>> diff --git a/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
>> new file mode 100644
>> index 000000000000..c068b9bb5bfd
>> --- /dev/null
>> +++ b/arch/riscv/boot/dts/microchip/mpfs-disco-kit.dts
>
> ...
>
>> +&mbox {
>> + status = "okay";
>> +};
>> +
>> +&mmc {
>> + bus-width = <4>;
>> + disable-wp;
>> + cap-sd-highspeed;
>> + cap-mmc-highspeed;
>> + sd-uhs-sdr12;
>> + sd-uhs-sdr25;
>> + sd-uhs-sdr50;
>> + sd-uhs-sdr104;
>
> I think sd-uhs-sdr104 implies sd-uhs-sdr{12,25,50}, thus the latter
> three properties could be dropped.
Even though the kernel treats sd-uhs-sdr104 as implying support for
sdr12, sdr25, and sdr50, the binding has no such rules about implying
other modes. For this reason, I thought it could be valid to explicitly
list all supported modes to ensure accurate hw representation.>
>> + no-1-8-v;
>> + status = "okay";
>> +};
>
> Best regards,
> Yao Zi
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2025-09-03 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 7:55 [PATCH v2 0/5] Icicle Kit with prod device and Discovery Kit support Valentina Fernandez
2025-09-02 7:55 ` [PATCH v2 1/5] riscv: dts: microchip: add common board dtsi for icicle kit variants Valentina Fernandez
2025-09-02 7:55 ` [PATCH v2 2/5] dt-bindings: riscv: microchip: document icicle kit with production device Valentina Fernandez
2025-09-02 7:55 ` [PATCH v2 3/5] riscv: dts: microchip: add " Valentina Fernandez
2025-09-02 7:55 ` [PATCH v2 4/5] dt-bindings: riscv: microchip: document Discovery Kit Valentina Fernandez
2025-09-02 7:55 ` [PATCH v2 5/5] riscv: dts: microchip: add a device tree for " Valentina Fernandez
2025-09-02 8:32 ` Yao Zi
2025-09-03 9:43 ` Valentina.FernandezAlanis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b371196-c853-4e47-980f-3f2b3525180e@microchip.com \
--to=valentina.fernandezalanis@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox