From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B963C5B543 for ; Fri, 6 Jun 2025 00:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZuLzoojzNzhVyIsLf6xqHv+XLZFxjjW3HqTkMorWDYw=; b=z0WVspdoVAbU1K GXL3Bz78NcmS7EeXxZZifJ7uSQHIo/DgK16Ai0ZTLRnGEyKJEMPNydeVc1HjDk4bs481W+t03DpLc 9A5410KqzeNjcE38urrPuKRQ6ey75mF9i8+uIvuc1seIZMDAX4I+rldTLWxijDwr4etbQv6lli4g0 zzkzjsDLsJ7+hpN3jo8Y2QMnOS0DI1Bry/fqTITs09Oug5ILHe1oXdvW2l1ZhhTcMC5MO6/CQhOyD fufAOdqiEphwmu+me2a4eKSxwH3XI1mHeaRAp/g6/M8Kwq/mzzW8ebDXzmW9XNldQz4Vz+4A224Eq 6vw2UAoMo4ngMJnh/hPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNLKb-0000000Gs2G-0Ysk; Fri, 06 Jun 2025 00:53:13 +0000 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNLKY-0000000Gs14-0D6O; Fri, 06 Jun 2025 00:53:11 +0000 Message-ID: <8ca50309-fad7-438a-86d6-947cd39355fa@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749171185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kY1Yhf2Ta16lGAfQpv9nl7Dl6/dZF2m3DEDTNJAsF5Y=; b=EMie37qYZzEs8Rjw9lzqRaIyG0BkrIKeZAJmJltSqgZlWHSoD3LrX5cznfshPhNPFrabI7 OSLfNETKU251DBYbeFMpyzHpsDkkJPr/iZ7F2qHFaI2nvnKeM2nzLr2xHOncUVAXLwZSI4 tO0xRD2vfiqsbX6LUjiLm0p4c3MDyAA= Date: Thu, 5 Jun 2025 17:52:55 -0700 MIME-Version: 1.0 Subject: Re: [PATCH 04/13] RISC-V: KVM: Drop the return value of kvm_riscv_vcpu_aia_init() To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Andrew Jones , Anup Patel , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250605061458.196003-1-apatel@ventanamicro.com> <20250605061458.196003-5-apatel@ventanamicro.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: <20250605061458.196003-5-apatel@ventanamicro.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250605_175310_663939_C4A56F8C X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 6/4/25 11:14 PM, Anup Patel wrote: > The kvm_riscv_vcpu_aia_init() does not return any failure so drop > the return value which is always zero. > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/kvm_aia.h | 2 +- > arch/riscv/kvm/aia_device.c | 6 ++---- > arch/riscv/kvm/vcpu.c | 4 +--- > 3 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/arch/riscv/include/asm/kvm_aia.h b/arch/riscv/include/asm/kvm_aia.h > index 3b643b9efc07..0a0f12496f00 100644 > --- a/arch/riscv/include/asm/kvm_aia.h > +++ b/arch/riscv/include/asm/kvm_aia.h > @@ -147,7 +147,7 @@ int kvm_riscv_vcpu_aia_rmw_ireg(struct kvm_vcpu *vcpu, unsigned int csr_num, > > int kvm_riscv_vcpu_aia_update(struct kvm_vcpu *vcpu); > void kvm_riscv_vcpu_aia_reset(struct kvm_vcpu *vcpu); > -int kvm_riscv_vcpu_aia_init(struct kvm_vcpu *vcpu); > +void kvm_riscv_vcpu_aia_init(struct kvm_vcpu *vcpu); > void kvm_riscv_vcpu_aia_deinit(struct kvm_vcpu *vcpu); > > int kvm_riscv_aia_inject_msi_by_id(struct kvm *kvm, u32 hart_index, > diff --git a/arch/riscv/kvm/aia_device.c b/arch/riscv/kvm/aia_device.c > index 43e472ff3e1a..5b7ed2d987db 100644 > --- a/arch/riscv/kvm/aia_device.c > +++ b/arch/riscv/kvm/aia_device.c > @@ -539,12 +539,12 @@ void kvm_riscv_vcpu_aia_reset(struct kvm_vcpu *vcpu) > kvm_riscv_vcpu_aia_imsic_reset(vcpu); > } > > -int kvm_riscv_vcpu_aia_init(struct kvm_vcpu *vcpu) > +void kvm_riscv_vcpu_aia_init(struct kvm_vcpu *vcpu) > { > struct kvm_vcpu_aia *vaia = &vcpu->arch.aia_context; > > if (!kvm_riscv_aia_available()) > - return 0; > + return; > > /* > * We don't do any memory allocations over here because these > @@ -556,8 +556,6 @@ int kvm_riscv_vcpu_aia_init(struct kvm_vcpu *vcpu) > /* Initialize default values in AIA vcpu context */ > vaia->imsic_addr = KVM_RISCV_AIA_UNDEF_ADDR; > vaia->hart_index = vcpu->vcpu_idx; > - > - return 0; > } > > void kvm_riscv_vcpu_aia_deinit(struct kvm_vcpu *vcpu) > diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c > index 6a1914b21ec3..f98a1894d55b 100644 > --- a/arch/riscv/kvm/vcpu.c > +++ b/arch/riscv/kvm/vcpu.c > @@ -160,9 +160,7 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu) > kvm_riscv_vcpu_pmu_init(vcpu); > > /* Setup VCPU AIA */ > - rc = kvm_riscv_vcpu_aia_init(vcpu); > - if (rc) > - return rc; > + kvm_riscv_vcpu_aia_init(vcpu); > > /* > * Setup SBI extensions _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv