public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Minda Chen <minda.chen@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Mason Huo" <mason.huo@starfivetech.com>,
	"Leyfoon Tan" <leyfoon.tan@starfivetech.com>,
	"Kevin Xie" <kevin.xie@starfivetech.com>
Subject: Re: [PATCH v8 10/22] PCI: plda: Add PLDA default event IRQ handler
Date: Wed, 18 Oct 2023 18:50:30 +0800	[thread overview]
Message-ID: <8dfdc8a5-339a-43e8-8d82-0597a6187336@starfivetech.com> (raw)
In-Reply-To: <20231018-escapable-chef-16572cda2c12@spud>



On 2023/10/18 18:44, Conor Dooley wrote:
> On Wed, Oct 11, 2023 at 07:05:02PM +0800, Minda Chen wrote:
>> Add PLDA default event IRQ handler.
>> This is first patch of refactoring IRQ handling codes.
>> The handler function will be referenced by later patch.
>> 
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> ---
>>  drivers/pci/controller/plda/pcie-plda-host.c | 5 +++++
>>  drivers/pci/controller/plda/pcie-plda.h      | 1 +
> 
> Dunno what hte PCI maintainers take is on this kind of thing, but this
> patch adds dead code, as there is no user for it until the follow-on
> patch you mention. Did someone ask you to split this out?
> 
> Cheers,
> Conor.
> 
No one. Previous this patch contain other codes. I modify this incorrect.  I will squash this with other patch. Thanks.
>>  2 files changed, 6 insertions(+)
>> 
>> diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/controller/plda/pcie-plda-host.c
>> index 19131181897f..21ca6b460f5e 100644
>> --- a/drivers/pci/controller/plda/pcie-plda-host.c
>> +++ b/drivers/pci/controller/plda/pcie-plda-host.c
>> @@ -18,6 +18,11 @@
>>  
>>  #include "pcie-plda.h"
>>  
>> +irqreturn_t plda_event_handler(int irq, void *dev_id)
>> +{
>> +	return IRQ_HANDLED;
>> +}
>> +
>>  void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
>>  			    phys_addr_t axi_addr, phys_addr_t pci_addr,
>>  			    size_t size)
>> diff --git a/drivers/pci/controller/plda/pcie-plda.h b/drivers/pci/controller/plda/pcie-plda.h
>> index 3deefd35fa5a..7ff7ff44c980 100644
>> --- a/drivers/pci/controller/plda/pcie-plda.h
>> +++ b/drivers/pci/controller/plda/pcie-plda.h
>> @@ -120,6 +120,7 @@ struct plda_pcie_rp {
>>  	void __iomem *bridge_addr;
>>  };
>>  
>> +irqreturn_t plda_event_handler(int irq, void *dev_id);
>>  void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
>>  			    phys_addr_t axi_addr, phys_addr_t pci_addr,
>>  			    size_t size);
>> -- 
>> 2.17.1
>> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-10-18 10:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 11:04 [PATCH v8 0/22] Refactoring Microchip PCIe driver and add StarFive PCIe Minda Chen
2023-10-11 11:04 ` [PATCH v8 01/22] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties Minda Chen
2023-10-11 11:04 ` [PATCH v8 02/22] PCI: microchip: Move pcie-microchip-host.c to plda directory Minda Chen
2023-10-11 11:04 ` [PATCH v8 03/22] PCI: microchip: Move PLDA IP register macros to pcie-plda.h Minda Chen
2023-10-11 11:04 ` [PATCH v8 04/22] PCI: microchip: Add bridge_addr field to struct mc_pcie Minda Chen
2023-10-18 10:39   ` Conor Dooley
2023-10-11 11:04 ` [PATCH v8 05/22] PCI: microchip: Rename two PCIe data structures Minda Chen
2023-10-18 10:40   ` Conor Dooley
2023-10-11 11:04 ` [PATCH v8 06/22] PCI: microchip: Move PCIe host data structure to plda-pcie.h Minda Chen
2023-10-18 10:41   ` Conor Dooley
2023-10-11 11:04 ` [PATCH v8 07/22] PCI: microchip: Rename two setup functions Minda Chen
2023-10-11 11:05 ` [PATCH v8 08/22] PCI: microchip: Change the argument of plda_pcie_setup_iomems() Minda Chen
2023-10-11 11:05 ` [PATCH v8 09/22] PCI: microchip: Move the setup functions to pcie-plda-host.c Minda Chen
2023-10-11 11:05 ` [PATCH v8 10/22] PCI: plda: Add PLDA default event IRQ handler Minda Chen
2023-10-18 10:44   ` Conor Dooley
2023-10-18 10:50     ` Minda Chen [this message]
2023-10-11 11:05 ` [PATCH v8 11/22] PCI: microchip: Rename interrupt related functions Minda Chen
2023-10-11 11:05 ` [PATCH v8 12/22] PCI: microchip: Add num_events field to struct plda_pcie_rp Minda Chen
2023-10-11 11:05 ` [PATCH v8 13/22] PCI: microchip: Add request_event_irq() callback function Minda Chen
2023-10-18 10:53   ` Conor Dooley
2023-10-11 11:05 ` [PATCH v8 14/22] PCI: microchip: Add INTx and MSI event num to struct plda_event Minda Chen
2023-10-11 11:05 ` [PATCH v8 15/22] PCI: microchip: Add get_events() callback function Minda Chen
2023-10-18 11:27   ` Conor Dooley
2023-10-11 11:05 ` [PATCH v8 16/22] PCI: microchip: Add event IRQ domain ops to struct plda_event Minda Chen
2023-10-18 11:30   ` Conor Dooley
2023-10-19  7:39     ` Minda Chen
2023-10-11 11:05 ` [PATCH v8 17/22] PCI: microchip: Move IRQ functions to pcie-plda-host.c Minda Chen
2023-10-11 11:05 ` [PATCH v8 18/22] PCI: plda: Set plda_event_handler() to static Minda Chen
2023-10-11 11:05 ` [PATCH v8 19/22] PCI: plda: Add event interrupt codes and IRQ domain ops Minda Chen
2023-10-11 11:05 ` [PATCH v8 20/22] dt-bindings: PCI: Add StarFive JH7110 PCIe controller Minda Chen
2023-10-11 11:05 ` [PATCH v8 21/22] PCI: starfive: Add " Minda Chen
2023-10-11 11:05 ` [PATCH v8 22/22] riscv: dts: starfive: add PCIe dts configuration for JH7110 Minda Chen
2023-10-17  5:43 ` [PATCH v8 0/22] Refactoring Microchip PCIe driver and add StarFive PCIe Minda Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dfdc8a5-339a-43e8-8d82-0597a6187336@starfivetech.com \
    --to=minda.chen@starfivetech.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhelgaas@google.com \
    --cc=conor@kernel.org \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=kevin.xie@starfivetech.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mason.huo@starfivetech.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox