Re: [PATCH v11 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC

From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Inochi Amaoto <inochiama@gmail.com>,
	devicetree@vger.kernel.org,  linux-riscv@lists.infradead.org,
	linux-rtc@vger.kernel.org
Cc: Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
	alexandre.belloni@bootlin.com,  robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	 unicorn_wang@outlook.com, inochiama@outlook.com,
	paul.walmsley@sifive.com,  palmer@dabbelt.com,
	aou@eecs.berkeley.edu, dlan@gentoo.org,
	 linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v11 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC
Date: Fri, 14 Feb 2025 12:09:37 +0100	[thread overview]
Message-ID: <964a016b944b459a9a914abac539350769323259.camel@gmail.com> (raw)
In-Reply-To: <t6z6rikut2him5m57b6xubbguw3llczp4i6d5frcpuhlqihf2d@booethzadxsq>

Hi Inochi,

On Fri, 2025-02-14 at 17:40 +0800, Inochi Amaoto wrote:
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    rtc@5025000 {
> > +        compatible = "sophgo,cv1800-rtc";
> > +        reg = <0x5025000 0x2000>;
> > +        interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&osc>;
> > +    };
> > -- 
> 
> Just for curiosity, Do you leave a way to implement the
> 8051 subsys, since its registers are in rtc. (You can
> check the chapter "8051 subsystem" of the SG2002, which
> can be found at https://github.com/sophgo/sophgo-doc).

well, I suppose, you know the answer, according to how this has been modelled
within this series, all the functionality could only be added on top of RTC
driver. Do you think it's time to re-design it as compatible = "syscon", "simple-mfd"
with children nodes for RTC and reboot?

-- 
Alexander Sverdlin.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv