Re: [PATCH v4 12/19] clk: starfive: Add StarFive JH7110 always-on clock driver

Hal Feng
2023-03-09T09:44:27Z

On Tue, 28 Feb 2023 10:42:35 +0800, Hal Feng wrote:
> On Sun, 26 Feb 2023 18:34:52 +0100, Emil Renner Berthing wrote:
>> On Tue, 21 Feb 2023 at 03:47, Hal Feng <hal.feng@starfivetech.com> wrote:
>>> From: Emil Renner Berthing <kernel@esmil.dk>
>>>
>>> Add driver for the StarFive JH7110 always-on clock controller
>>> and register an auxiliary device for always-on reset controller
>>> which is named as "reset-aon".
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Co-developed-by: Hal Feng <hal.feng@starfivetech.com>
>>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>>> ---
>>> drivers/clk/starfive/Kconfig | 11 ++
>>> drivers/clk/starfive/Makefile | 1 +
>>> .../clk/starfive/clk-starfive-jh7110-aon.c | 156 ++++++++++++++++++
>>> 3 files changed, 168 insertions(+)
>>> create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-aon.c
>>>
>>> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig
>>> index 4640d0665d1c..2aa664f2cdee 100644
>>> --- a/drivers/clk/starfive/Kconfig
>>> +++ b/drivers/clk/starfive/Kconfig
>>> @@ -31,3 +31,14 @@ config CLK_STARFIVE_JH7110_SYS
>>> help
>>> Say yes here to support the system clock controller on the
>>> StarFive JH7110 SoC.
>>> +
>>> +config CLK_STARFIVE_JH7110_AON
>>> + tristate "StarFive JH7110 always-on clock support"
>>> + depends on CLK_STARFIVE_JH7110_SYS
>>> + select AUXILIARY_BUS
>>> + select CLK_STARFIVE_JH71X0
>>> + select RESET_STARFIVE_JH7110
>>> + default CLK_STARFIVE_JH7110_SYS
>>
>> As far as I can tell the JH7110 boots fine without this driver and it
>> already depends on the _SYS driver above, so please do
>>
>> default m if SOC_STARFIVE
>
> OK. Will fix it.

Hi, Emil,

The AON clock driver provides clocks for gmac0 which is used frequently.
So I think it would be more convenient if we set "default y" here.

Best regards,
Hal