Re: [PATCH 04/47] arm64: dts: qcom: qcs9100: Add QCS9100 RIDE board dts

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
	andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, djakov@kernel.org,
	mturquette@baylibre.com, sboyd@kernel.org,
	jassisinghbrar@gmail.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, manivannan.sadhasivam@linaro.org,
	will@kernel.org, joro@8bytes.org, conor@kernel.org,
	tglx@linutronix.de, amitk@kernel.org, thara.gopinath@gmail.com,
	linus.walleij@linaro.org, wim@linux-watchdog.org,
	linux@roeck-us.net, rafael@kernel.org, viresh.kumar@linaro.org,
	vkoul@kernel.org, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, mcoquelin.stm32@gmail.com
Cc: robimarko@gmail.com, quic_gurus@quicinc.com,
	bartosz.golaszewski@linaro.org, kishon@kernel.org,
	quic_wcheng@quicinc.com, alim.akhtar@samsung.com,
	avri.altman@wdc.com, bvanassche@acm.org, agross@kernel.org,
	gregkh@linuxfoundation.org, quic_tdas@quicinc.com,
	robin.murphy@arm.com, daniel.lezcano@linaro.org,
	rui.zhang@intel.com, lukasz.luba@arm.com,
	quic_rjendra@quicinc.com, ulf.hansson@linaro.org,
	quic_sibis@quicinc.com, otto.pflueger@abscue.de,
	quic_rohiagar@quicinc.com, luca@z3ntu.xyz,
	neil.armstrong@linaro.org, abel.vesa@linaro.org,
	bhupesh.sharma@linaro.org, alexandre.torgue@foss.st.com,
	peppe.cavallaro@st.com, joabreu@synopsys.com,
	netdev@vger.kernel.org, lpieralisi@kernel.org, kw@linux.com,
	bhelgaas@google.com, ahalaney@redhat.com,
	krzysztof.kozlowski@linaro.org, u.kleine-koenig@pengutronix.de,
	dmitry.baryshkov@linaro.org, quic_cang@quicinc.com,
	danila@jiaxyga.com, quic_nitirawa@quicinc.com,
	mantas@8devices.com, athierry@redhat.com,
	quic_kbajaj@quicinc.com, quic_bjorande@quicinc.com,
	quic_msarkar@quicinc.com, quic_devipriy@quicinc.com,
	quic_tsoni@quicinc.com, quic_rgottimu@quicinc.com,
	quic_shashim@quicinc.com, quic_kaushalk@quicinc.com,
	quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
	srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-crypto@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com, kernel@quicinc.com
Subject: Re: [PATCH 04/47] arm64: dts: qcom: qcs9100: Add QCS9100 RIDE board dts
Date: Wed, 3 Jul 2024 06:39:10 +0200	[thread overview]
Message-ID: <9b739f4a-c9e1-4d2a-9bec-83106dcf8868@kernel.org> (raw)
In-Reply-To: <20240703025850.2172008-5-quic_tengfan@quicinc.com>

On 03/07/2024 04:58, Tengfei Fan wrote:
> Add support for the QCS9100 RIDE board dts. The current QCS9100 RIDE
> board dts is directly renamed from the SA8775p RIDE board dts.
> The difference between the current QCS9100 RIDE board and the SA8775p
> RIDE board lies solely in the replacement of the SA8775p SoC with the
> QCS9100 SoC, all other board resources remain the same.
> The following items have been updated:
>   - use QCS9100-related compatible names for this board dts.
>   - replace the inclusion of sa8775p.dtsi with qcs9100.dtsi.
>   - replace the inclusion of sa8775p-pmics.dtsi with qcs9100-pmics.dtsi
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile                         | 2 +-
>  .../boot/dts/qcom/{sa8775p-ride.dts => qcs9100-ride.dts}  | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>  rename arch/arm64/boot/dts/qcom/{sa8775p-ride.dts => qcs9100-ride.dts} (99%)
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 5576c7d6ea06..a7a3792b0691 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-1000.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs404-evb-4000.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-aim300-aiot.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qdu1000-idp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qrb2210-rb1.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qrb4210-rb2.dtb
> @@ -112,7 +113,6 @@ dtb-$(CONFIG_ARCH_QCOM)	+= qru1000-idp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sa8155p-adp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sa8295p-adp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sa8540p-ride.dtb
> -dtb-$(CONFIG_ARCH_QCOM)	+= sa8775p-ride.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-acer-aspire1.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-idp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sc7180-trogdor-coachz-r1.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> similarity index 99%
> rename from arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> rename to arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> index 26ad05bd3b3f..2415d34b8aa5 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts
> @@ -8,12 +8,12 @@
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  
> -#include "sa8775p.dtsi"
> -#include "sa8775p-pmics.dtsi"
> +#include "qcs9100.dtsi"
> +#include "qcs9100-pmics.dtsi"
>  
>  / {
> -	model = "Qualcomm SA8775P Ride";
> -	compatible = "qcom,sa8775p-ride", "qcom,sa8775p";
> +	model = "Qualcomm QCS9100 Ride";
> +	compatible = "qcom,qcs9100-ride", "qcom,qcs9100";

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Your own internal guideline tells you to perform above tests, doesn't it?

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv