Re: [RFC v3 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node

Krzysztof Kozlowski
2025-01-21T09:52:39Z

On Mon, Jan 20, 2025 at 06:20:56PM +0100, Michal Wilczynski wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0fa7c5728f1e..c56a1fb6e02a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20184,6 +20184,7 @@ M: Fu Wei <wefu@redhat.com>
> L: linux-riscv@lists.infradead.org
> S: Maintained
> T: git https://github.com/pdp7/linux.git
> +F: Documentation/devicetree/bindings/firmware/thead,th1520-aon.yaml
> F: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.yaml

Misordered.

> F: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.yaml
> F: Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> @@ -20194,6 +20195,7 @@ F: drivers/mailbox/mailbox-th1520.c
> F: drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c
> F: drivers/pinctrl/pinctrl-th1520.c
> F: include/dt-bindings/clock/thead,th1520-clk-ap.h
> +F: include/dt-bindings/firmware/thead,th1520-aon.h
>
> RNBD BLOCK DRIVERS
> M: Md. Haris Iqbal <haris.iqbal@ionos.com>
> diff --git a/include/dt-bindings/firmware/thead,th1520-aon.h b/include/dt-bindings/firmware/thead,th1520-aon.h
> new file mode 100644
> index 000000000000..7607522289f7
> --- /dev/null
> +++ b/include/dt-bindings/firmware/thead,th1520-aon.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (C) 2022 Alibaba Group Holding Limited.
> + * Copyright (c) 2024 Samsung Electronics Co., Ltd.
> + * Author: Michal Wilczynski <m.wilczynski@samsung.com>
> + */
> +
> +#ifndef __DT_BINDINGS_AON_TH1520_H
> +#define __DT_BINDINGS_AON_TH1520_H
> +
> +#define TH1520_AON_VDEC_PD 1
> +#define TH1520_AON_NPU_PD 2
> +#define TH1520_AON_VENC_PD 3
> +#define TH1520_AON_GPU_PD 4
> +#define TH1520_AON_DSP0_PD 5
> +#define TH1520_AON_DSP1_PD 6

I don't see these being used in the driver. Can you point me?

Best regards,
Krzysztof