From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E20C388F7 for ; Tue, 10 Nov 2020 17:18:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F74206F1 for ; Tue, 10 Nov 2020 17:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJsrDUNV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WGKyvXwW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8F74206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HOoFAbEG7traYXjatp77OEjAIvpVBQoNlzpJ57B/COo=; b=EJsrDUNVruPd+icxMJArsuzeg DvlJj/wTgoho3euF/5n7sdAGmjcKgL/d3VW8eQFl1Qi0axIhXFG4VtA2d9Oe6k+EC6drh/TVHFVRo lyuVYXCdY3uitPF6LNCPg6kaq15DV9qsl6w1bZH7nx0nSW4cdDXjNB7n67TyU2toAWUErqjOsV1jo J6qz87n3olTmy7aE3+9J4YQz4FccaexeKLkL6bKfAuUeOOQjKvxtX5yRERwFD0Ax5+Q2MPwaE08Lr uZctVqaS4jxxOprJeYQDQxVu3ZOkSbzW7OwfhcsJLoW8HrgLynUD9QWEVjNN/A9irgaey/PJHbcVF 7X3D62OIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcXHB-0001zW-1W; Tue, 10 Nov 2020 17:17:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcXH7-0001wM-Bs for linux-riscv@lists.infradead.org; Tue, 10 Nov 2020 17:17:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605028662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LzJjyVY4ylm22B+GsjUVJTMLO29F4ZbRIlWrsGH0w2g=; b=WGKyvXwWUPQdJETyBQ7x+8qm+K8+KAkfS67ZsYyOD5z+T59gT26SZ8M+oHhdgxohJNiFmi zmnfGzvBv3M930oCmUkWlu6L6kgkHVlYWkrvevOFLgE8upwB51nzSjjjEnJpF4S9ApvRFS mxv1UH3rqskLaT+vfDwk8IJs7KhKU8Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-X1NkAVToMrqmIhC-vp3-wQ-1; Tue, 10 Nov 2020 12:17:40 -0500 X-MC-Unique: X1NkAVToMrqmIhC-vp3-wQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CAE7D11BD341; Tue, 10 Nov 2020 17:17:34 +0000 (UTC) Received: from [10.36.114.232] (ovpn-114-232.ams2.redhat.com [10.36.114.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FDB65D9D2; Tue, 10 Nov 2020 17:17:27 +0000 (UTC) Subject: Re: [PATCH v8 2/9] mmap: make mlock_future_check() global To: Mike Rapoport , Andrew Morton References: <20201110151444.20662-1-rppt@kernel.org> <20201110151444.20662-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9e2fafd7-abb0-aa79-fa66-cd8662307446@redhat.com> Date: Tue, 10 Nov 2020 18:17:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201110151444.20662-3-rppt@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_121745_593490_0D32FE79 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Shuah Khan , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Will Deacon , x86@kernel.org, Matthew Wilcox , Mike Rapoport , Ingo Molnar , Michael Kerrisk , Arnd Bergmann , James Bottomley , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-fsdevel@vger.kernel.org, Rick Edgecombe Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 10.11.20 16:14, Mike Rapoport wrote: > From: Mike Rapoport > > It will be used by the upcoming secret memory implementation. > > Signed-off-by: Mike Rapoport > --- > mm/internal.h | 3 +++ > mm/mmap.c | 5 ++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index c43ccdddb0f6..ae146a260b14 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -348,6 +348,9 @@ static inline void munlock_vma_pages_all(struct vm_area_struct *vma) > extern void mlock_vma_page(struct page *page); > extern unsigned int munlock_vma_page(struct page *page); > > +extern int mlock_future_check(struct mm_struct *mm, unsigned long flags, > + unsigned long len); > + > /* > * Clear the page's PageMlocked(). This can be useful in a situation where > * we want to unconditionally remove a page from the pagecache -- e.g., > diff --git a/mm/mmap.c b/mm/mmap.c > index 61f72b09d990..c481f088bd50 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1348,9 +1348,8 @@ static inline unsigned long round_hint_to_min(unsigned long hint) > return hint; > } > > -static inline int mlock_future_check(struct mm_struct *mm, > - unsigned long flags, > - unsigned long len) > +int mlock_future_check(struct mm_struct *mm, unsigned long flags, > + unsigned long len) > { > unsigned long locked, lock_limit; > > So, an interesting question is if you actually want to charge secretmem pages against mlock now, or if you want a dedicated secretmem cgroup controller instead? -- Thanks, David / dhildenb _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv