From: arnd@arndb.de (Arnd Bergmann)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v3 3/7] riscv: Delete asm/compat.h
Date: Sun, 5 Aug 2018 23:29:30 +0200 [thread overview]
Message-ID: <CAK8P3a2i2Por7Xy_7GQEbdOx_CW4jF69MW3VXqc8AnxFjEd4BQ@mail.gmail.com> (raw)
In-Reply-To: <20180803073916.GA19580@infradead.org>
On Fri, Aug 3, 2018 at 9:39 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Aug 02, 2018 at 06:26:58PM -0700, Palmer Dabbelt wrote:
>> I thought we were using this to make uname print "riscv64" (or "riscv32")
>> instead of just "riscv"? Is there another mechanism to do that?
>
> That is set in the UTS_MACHINE variable in arch/riscv/Makefile
> and doesn't involve compat.h at all except when actually implementing
> 32-bit compat on 64 bit, which RISC-V doesn't (at least yet).
Note that the logic was also wrong, if we had an implementation of
CONFIG_COMPAT for arch/riscv, it would always result in the
"riscv64" string for both PER_LINUX and PER_LINUX32, when
it should be "riscv32" for the PER_LINUX32 personaliy.
Arnd
prev parent reply other threads:[~2018-08-05 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 5:42 [PATCH v3 0/7] Introduce struct __kernel_timex Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 3/7] riscv: Delete asm/compat.h Deepa Dinamani
2018-07-12 8:14 ` Christoph Hellwig
2018-08-03 1:26 ` Palmer Dabbelt
2018-08-03 7:39 ` Christoph Hellwig
2018-08-05 21:29 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2i2Por7Xy_7GQEbdOx_CW4jF69MW3VXqc8AnxFjEd4BQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).