From: Zong Li <zong.li@sifive.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Conor Dooley <conor.dooley@microchip.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Bin Meng <bin.meng@windriver.com>,
Green Wan <green.wan@sifive.com>,
dmaengine <dmaengine@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] riscv: dts: Add dma-channels property in dma node
Date: Thu, 27 Jan 2022 15:35:21 +0800 [thread overview]
Message-ID: <CANXhq0qX_TZTRyZGGBSs0_zUa87ktSSv-CubHF8pFxuhv7rocA@mail.gmail.com> (raw)
In-Reply-To: <YfJD11wlgkzuE+Sp@matsya>
On Thu, Jan 27, 2022 at 3:03 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 17-01-22, 09:35, Zong Li wrote:
> > Add dma-channels property, then we can determine how many channels there
> > by device tree.
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 1 +
> > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > index c9f6d205d2ba..3c48f2d7a4a4 100644
> > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > @@ -188,6 +188,7 @@ dma@3000000 {
>
> Unrelated but the node name should be dma-controller@...
>
Thanks for the correction, I guess we could give another patch for
changing the node name.
> > reg = <0x0 0x3000000 0x0 0x8000>;
> > interrupt-parent = <&plic>;
> > interrupts = <23 24 25 26 27 28 29 30>;
> > + dma-channels = <4>;
> > #dma-cells = <1>;
> > };
> >
> > diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> > index 0655b5c4201d..2bdfe7f06e4b 100644
> > --- a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> > +++ b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi
> > @@ -171,6 +171,7 @@ dma: dma@3000000 {
> > reg = <0x0 0x3000000 0x0 0x8000>;
> > interrupt-parent = <&plic0>;
> > interrupts = <23 24 25 26 27 28 29 30>;
> > + dma-channels = <4>;
> > #dma-cells = <1>;
> > };
> > uart1: serial@10011000 {
> > --
> > 2.31.1
>
> --
> ~Vinod
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-01-27 7:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 1:35 [PATCH v4 0/3] Determine the number of DMA channels by 'dma-channels' property Zong Li
2022-01-17 1:35 ` [PATCH v4 1/3] riscv: dts: Add dma-channels property in dma node Zong Li
2022-01-18 15:04 ` Conor.Dooley
2022-01-20 18:51 ` Palmer Dabbelt
2022-01-27 7:03 ` Vinod Koul
2022-01-27 7:35 ` Zong Li [this message]
2022-01-17 1:35 ` [PATCH v4 2/3] dt-bindings: Add dma-channels for pdma device node Zong Li
2022-01-20 18:51 ` Palmer Dabbelt
2022-01-21 1:57 ` Zong Li
2022-01-17 1:35 ` [PATCH v4 3/3] dmaengine: sf-pdma: Get number of channel by device tree Zong Li
2022-01-20 18:51 ` Palmer Dabbelt
2022-01-21 2:21 ` Zong Li
2022-01-21 8:33 ` Geert Uytterhoeven
2022-01-21 10:29 ` Zong Li
2022-01-25 5:08 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANXhq0qX_TZTRyZGGBSs0_zUa87ktSSv-CubHF8pFxuhv7rocA@mail.gmail.com \
--to=zong.li@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=green.wan@sifive.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).