From: "Matthew Bystrin" <dev.mbstr@gmail.com>
To: "Samuel Holland" <samuel.holland@sifive.com>
Cc: <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 2/4] riscv: entry: Balance vector context nesting
Date: Fri, 07 Jun 2024 00:36:40 +0300 [thread overview]
Message-ID: <D1T9B0RLBAB6.2TS7V4IYKR84M@gmail.com> (raw)
In-Reply-To: <20240530001733.1407654-3-samuel.holland@sifive.com>
Hi! Thanks for the patch!
On Thu May 30, 2024 at 3:15 AM MSK, Samuel Holland wrote:
> Vector context management is the last thing done before jumping to C
> code, so it should be the first thing done after returning from C code.
> This also improves efficiency: riscv_v_context_nesting_end() clobbers
> the saved value of the status CSR, so currently ret_from_exception()
> must reload it. This is not necessary if riscv_v_context_nesting_end()
> is called first.
IIUC this patch do not improves efficiency by itself, because reload of CSR
stays in place. What do think about applying here s1 register related changes
from the next patch? Is it reasonable? Or you can describe this patch in a
different way, like it makes preparations for efficiency improvements.
--
Best regards,
Matthew Bystrin <dev.mbstr@gmail.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-06-06 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 0:15 [PATCH 0/4] riscv: Frame pointer fixes and enhancements Samuel Holland
2024-05-30 0:15 ` [PATCH 1/4] riscv: Fix 32-bit call_on_irq_stack() frame pointer ABI Samuel Holland
2024-06-06 20:09 ` Matthew Bystrin
2024-05-30 0:15 ` [PATCH 2/4] riscv: entry: Balance vector context nesting Samuel Holland
2024-06-06 21:36 ` Matthew Bystrin [this message]
2024-05-30 0:15 ` [PATCH 3/4] riscv: entry: Do not clobber the frame pointer Samuel Holland
2024-06-11 5:34 ` Andy Chiu
2024-05-30 0:15 ` [PATCH 4/4] riscv: entry: Save a frame record for exceptions Samuel Holland
2024-05-30 13:36 ` kernel test robot
2024-05-30 14:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1T9B0RLBAB6.2TS7V4IYKR84M@gmail.com \
--to=dev.mbstr@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox