From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35DADEE6428 for ; Wed, 31 Dec 2025 14:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Subject: Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p/WH5RGFgd2hbe/hcsR7Bp3yabAAlrA5+fjtQ0WUgnU=; b=gzET8zxDMSbcAJ 7p6NQDIYoTWvb526avxxWTHDme/8LqS5/QrRTJcnUqpxbIFXNuRfv2erRYxQ/Ca0mtFtNZyoS336I 65deiefeAVPsPG2X5rGfB99txzivpjRHy84w+D58AnC6nXW83tOaotJbrVJ9/mir+UfxPuC23V939 XH5Atn5sti6To+nbG+AmNaXprhPyCChwUoUhixlUNCqVq1eW6wq9HvxWXOQWSqh8AK0NnMrfLGe1O l2/cFrgOmugDYCE3KM5hkRzIj3wrsr/S2JEK79gs+oS9A9J9C/i486DBBQs+TUYLhNmZCgHAxicgX 3DLE6yVx22QhpvZdZSQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vax4I-00000006282-3jIH; Wed, 31 Dec 2025 14:20:54 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vax4F-0000000627e-2tsm for linux-riscv@lists.infradead.org; Wed, 31 Dec 2025 14:20:53 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id A8741C1AE2B; Wed, 31 Dec 2025 14:20:06 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 24E1D60744; Wed, 31 Dec 2025 14:20:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D1397113B0770; Wed, 31 Dec 2025 15:20:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767190830; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=s/LBclbjVdapialdhCPRdRaESKqlpOnpyxq4+NMgleQ=; b=13wHxziny/E58+NBQrqX+3oqwXTJN93YZxWKmfk5Vk+lqAW1vaeCJkJLSB+5n0yxC5C0i6 peGkD9i2Lg28sPjmOWunBbHe1zqqgF4XTN44q8Uzl7NhT7l6RKxtK9qDxicfDKP/68Zdon ju0bXrBWNhg3k9kYcMUK0beztObZRm4JPE3U9sEkhvXyTcuK333O6r8kXtLaEWhYvMQD2u 6wlC3QxgUhFpBujq2T3zNWeMC8TdZ9bsKGNgxiC4jF48r6qANgMY/1mv3ZyhcuMP8j0bcp 8785748qfhPRghOe6yvJgSmnhDkzlaOHBtvUyKUu5H4/KFh4FcxTeIH6mHrawQ== Mime-Version: 1.0 Date: Wed, 31 Dec 2025 15:20:19 +0100 Message-Id: Subject: Re: [PATCH v4 3/9] drm: verisilicon: add a driver for Verisilicon display controllers To: "Icenowy Zheng" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Drew Fustini" , "Guo Ren" , "Fu Wei" , "Philipp Zabel" , "Heiko Stuebner" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Michal Wilczynski" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> <20251224161205.1132149-4-zhengxingda@iscas.ac.cn> In-Reply-To: <20251224161205.1132149-4-zhengxingda@iscas.ac.cn> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251231_062051_911685_268C8DE1 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Yao Zi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Han Gao , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed Dec 24, 2025 at 5:11 PM CET, Icenowy Zheng wrote: > From: Icenowy Zheng > > This is a from-scratch driver targeting Verisilicon DC-series display > controllers, which feature self-identification functionality like their > GC-series GPUs. > > Only DC8200 is being supported now, and only the main framebuffer is set > up (as the DRM primary plane). Support for more DC models and more > features is my further targets. > > As the display controller is delivered to SoC vendors as a whole part, > this driver does not use component framework and extra bridges inside a > SoC is expected to be implemented as dedicated bridges (this driver > properly supports bridge chaining). > > Signed-off-by: Icenowy Zheng > Signed-off-by: Icenowy Zheng [...] > +++ b/drivers/gpu/drm/verisilicon/vs_bridge.h > +struct vs_bridge { > + struct drm_bridge base; > + struct drm_encoder *enc; > + struct drm_connector *conn; > + > + struct vs_crtc *crtc; > + struct drm_bridge *next; It is a common convention to call this 'next_bridge'. This makes it easier to understand but also to grep and find similar patterns. For info, we are working to move to 'struct drm_bridge::next_bridge' [0] as you can see from example patches like [1]. However this currently applies only to drivers using of_drm_find_bridge(), so it does not affect your driver. I'm sorry I have seen your patch only at v4. [0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/3fdeae134ba956aacbd87d5532c025913c98fc49 [1] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/8f92a5fcbfe33f86b08f5f74dcc58a41425ea8c0 Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv