From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39839D2502E for ; Mon, 12 Jan 2026 01:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGIJ9+WnlWEcYfMSlOhGOmod3RalpaK7fEPGgD/8Aqk=; b=oTBQhWe+2I3mhL 7iReHhLdR2rVJmS9u5r6FKTdIFbc3dP2nRt+ZPOxTcng1ULjFdSsDaNd0m2o4pM7zXoDBfiKOF+ZW z41jFKs7ZM9HKk/QH7uAiTHb5CHJ4PuvhM25YHnHT9q/Vq2QOaF3DevYN33Fr60SWGDS4GxtXov3e Dqxv/zlbmt5cmTgIPrnCFeE1Tc02TUCVvPZkDG7IOcaoL52XKEyPKkd4yVKacWvq99vuPT1KuR0+o miAtynhySojmxRDa7D0k9STV37BIXtCY2fk2Z69Mems4PhNwsR7Fp6lQvjPdkr59ujHLD6L5oGbRY dILOEDa4g5pfsvo0OWNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vf75Z-00000004dzX-13EP; Mon, 12 Jan 2026 01:51:25 +0000 Received: from smtpbgeu2.qq.com ([18.194.254.142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vf75T-00000004dz2-0Fe8 for linux-riscv@lists.infradead.org; Mon, 12 Jan 2026 01:51:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1768182609; bh=vXgizy4wIkS+ntIQMrsglm/OU4vxbvEgmvJk8CbngJo=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=ljS1iWNyyDP7Izbtve5uuShlNoMFo+GAVtivObDIdHgOrEB+IDuMnhbK4tzroiNeQ M4fyUn6pyPDqBsCx1m8dQOmVO/DsVSxNgb7fRCUSJvcMj9pkidm+DyFkbCWEIVQM6U ayzcO9Z/nz06f+i5CcC0osniPle4r6NqMnNvlArU= X-QQ-mid: zesmtpgz7t1768182601td230d057 X-QQ-Originating-IP: d/IJDIFXP7NV4/kPf6kV6P2D6IG5d8UiUn9KgZOiZR8= Received: from = ( [183.48.247.110]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 12 Jan 2026 09:49:59 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 52625910496199400 EX-QQ-RecipientCnt: 13 Mime-Version: 1.0 Date: Mon, 12 Jan 2026 09:49:59 +0800 Message-Id: Cc: "Troy Mitchell" , "Lee Jones" , "Yixun Lan" , "Andi Shyti" , "Liam Girdwood" , "Mark Brown" , , , , , Subject: Re: [PATCH v4 3/3] rtc: spacemit: default module when MFD_SPACEMIT_P1 is enabled From: "Troy Mitchell" To: "Alex Elder" , "Alexandre Belloni" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251225-p1-kconfig-fix-v4-0-44b6728117c1@linux.spacemit.com> <20251225-p1-kconfig-fix-v4-3-44b6728117c1@linux.spacemit.com> <202512251653368b33c7e7@mail.local> <4c7c0f69-4732-4f62-970a-2a9273b3b5c7@riscstar.com> <20251230005142d1bfc6f7@mail.local> <6ca28183-1687-4ddc-8b3c-5e5be4255561@riscstar.com> <20260109223627b566d2b0@mail.local> In-Reply-To: X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: McnXz9EssJMzD/tsDuf0SJgGVRu2/Sr5Aev4csbGYmINtatJRn/yTKTL cNkXWVDoFueM4TVfh6PAh9T6B7H2BcO/zhEpGHhDcfaE1XAhW0FDBTh13hBCjvxs+t5+KAe eghkzXOqqygdwRlmrrv0IoxuB8PCCjG/8s2PytbvUURTSgZxKy4+ZbK+3UnfZ/FuFn/Bc9s mquaP6DzSwUmIyT50OlBMd2+AY9kMbrUVl39DrV18HyppEHDeo2tkb8lCiCmNDO/KhzVLXg tLb6lqDRSHJLcESE7kfdMqy9tdICtzSdbUEfanF1fLxCf9cQEeqLkDSHYiKeRIoR2zPWUYa N+nW946yuS9j20kkzFJ1PbMzRWt+cjF7X5ZhKwLgh1qei9lD7N+JfiBYbe5oL2GXnBBpZgN bJQGUDlviHccrlwUGEl8UfhQeKPeMXMic6rUXND3gQWg+DYsmA/PwesKJ5Gs28jLGApipDq Sgky0qOtYPX8n6zPHJIEPfdLLUjQOxWEvl9qYgwqm7SdGZaS2yuOKMwv7ttz5e8i4hvh5mL tFpiHt0fO3CRNVbxWVK2ipBcwWR0n0MBwwe34zVS+8YyG9So2trXap9x0VOC/Gdck4SbMIF EEyWF/I3XwFDJaq8Fst4EIdwGGNPF18e7b/T3XaqP2SDW6wgIqGSz5pkhfj/a9fFc8xfgDV R16I2uTxtWjAq+2grfpo3NUWV8JKwSnRGd9b53A6JAKarIZP3gf1jYUkRD3AgTbfhuv3/i3 QNTnyLOdN6QHYabGhjl9B8htdsaToruu2dw+FUtyAXJedW/iVbjD0q3N4nPRtSeLlWJql3S QcJQorXvyFcnM87Qn6HoinDI6+zCLLE26YjvWB9jCtLhTD69KpiB6PN3HWaxEVmFXbCk1na 3bwCq2vtdLkfDwc6v6WJNNthmXlWND9GA42FUK/8tXYfW7UTbyXoiuzDwHFt9tOeOlIWccR 0q/5qztWVjHZIJ0wdpwbWaN/UZgUz1zFArlZ9mTvuzPSQ3rOS7Y9qsrpcVy/DLoZs2TcQog tt9ArqhXhN2PFyhNOREtOhapGnp4lR3eQjmObhF3AvYBkwLbU5B0mrK0QFRL4= X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-QQ-RECHKSPAM: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260111_175119_583550_D75F0F16 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon Jan 12, 2026 at 3:55 AM CST, Alex Elder wrote: > On 1/9/26 4:36 PM, Alexandre Belloni wrote: >>> The purpose is to make the driver a module (not built-in) >>> when "defconfig" is used (without the need for any Kconfig >>> fragments to unselect things). >>> >>> >>> In arch/riscv/configs/defconfig, we have this: >>> CONFIG_ARCH_SPACEMIT=y >>> >>> In drivers/mfd/Kconfig b/drivers/mfd/Kconfig, we have this >>> (added by patch 2 in this series): >>> config MFD_SPACEMIT_P1 >>> default m if ARCH_SPACEMIT >>> >>> So when using defconfig (alone), MFD_SPACEMIT_P1 is set to m, >>> to benefit non-SpacemiT RISC-V platforms. >>> >>> This patch is trying to do the same thing for the RTC, >>> i.e. having RTC_DRV_SPACEMIT_P1 be defined as a module >>> by default. >>> >>> I think you understand. >> I'm sorry, I must be dumb but I don't understand. The current behaviour > > I think I'm the dumb one. I think I finally understand your > point. > >> is that when MFD_SPACEMIT_P1 is m, then the default value for >> RTC_DRV_SPACEMIT_P1 will be m. Since patch 2 makes it exactly that way >> (MFD_SPACEMIT_P set to m), I don't get why it is necessary to mess with >> the default of RTC_DRV_SPACEMIT_P1. > > Your point is that patch has no real effect, at least not > on the scenario I was talking about. > > I.e., I was saying this mattered for using defconfig alone. > But, as you point out, using defconfig alone gives us: > > ARCH_SPACMIT=y (in defconfig) > MFD_SPACEMIT_P1=m (from patch 2) > > And then, *without* this patch: > RTC_DRV_SPACEMIT_P1=MFD_SPACEMIT_P1 > meaning > RTC_DRV_SPACEMIT_P1=m > > And therefore there's no need for this patch to set the > default to m rather than MFD_SPACEMIT_P1. > Thanks Alex and Alexandre for the clarification. You're absolutely right - the patch is indeed redundant since RTC_DRV_SPACEMIT_P1 already inherits the correct default value (m) through its dependency on MFD_SPACEMIT_P1. I'll drop this patch in the next version and review the rest of the series for similar unnecessary default overrides. - Troy > > >> The current default behaviour of RTC_DRV_SPACEMIT_P1 seems to be the >> correct one and the proper fix is then patch 2. > > Yes, now I understand. I'm sorry about my confusion. > > -Alex _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv