Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c

From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sandie Cao" <sandie.cao@deepcomputing.io>,
	"Yixun Lan" <dlan@kernel.org>
Cc: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, <spacemit@lists.linux.dev>,
	<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Date: Mon, 20 Apr 2026 17:35:17 +0800	[thread overview]
Message-ID: <DHXVORP1EJ4M.1ZOO1F7UVW11@linux.spacemit.com> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.5595e961.9ee2.4959.8935.9a8f33812b0c@feishu.cn>

On Mon Apr 20, 2026 at 5:26 PM CST, Sandie Cao wrote:
> Hi, Lan & Troy & Krzysztof :
>
>> From: "Yixun Lan"<dlan@kernel.org>
>> Date:  Mon, Apr 20, 2026, 17:09
>
>> Hi Troy,
>> 
>> On 16:50 Mon 20 Apr     , Troy Mitchell wrote:
>> > On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
>> > > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
>> > >> On 20/04/2026 10:39, Sandie Cao wrote:
>> > >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
>> > >> 
>> > >> Missing space after main commit msg.
>> > >> 
>> > >>> Reported-by: kernel test robot <lkp@intel.com>
>> > >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>> > >>>
>> > >
>> > > Also, the file reported in above warning DOES NOT EXIST (I checked
>> > > next-20260414).
>> > In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
>> > 
>> > properties:
>> >   compatible:
>> >     enum:
>> >       - spacemit,k1-pinctrl
>> >       - spacemit,k3-pinctrl
>> > 
>> I think you refer to wrong file, which should be
>>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
>> 
>> > So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
>> > there are subtle differences between them.
>> > 
>> But yes, the idea is correct, so NAK to this patch
>> >                                   - Troy
>> 
>> -- 
>> Yixun Lan (dlan)
>> 
>
> Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. 
> And it meets dtscheck issue:
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>
> On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml.
> Or I use the wrong branch? 
Yes... You are using a wrong branch I think. 
The k1/dt-for-next branch in this repo is Dlan’s tree. Since DT bindings are not within
his purview, they aren't included there. I only mentioned this repository earlier to
show that the UART portion of the pinctrl dtsi has already been merged into it;
it wasn't intended to be used as your development base.
>
> And what should I do for my patch[1] ?  
I think you can use next-20260417 as your base commit.
Everything you need is available here.

                                      - Troy
>
> [1] https://lore.kernel.org/all/20260413060524.1235982-1-sandie.cao@deepcomputing.io/
> [2] https://github.com/spacemit-com/linux/tree/k1/for-next#
>
> Best regards
> Sandie


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv