From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69253C982DF for ; Fri, 18 Sep 2026 15:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject:Cc:Message-Id :Date:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OYBxd7TYYxXFvzFYjraAoMVMrpKQoK7mjjKTuh7txiw=; b=zoO4b6QxYaWH6XydqJK+fxEiTB xP0OXClKQclhoNhyCGLQUGr3EYtZgcxP8HgDD0xAN2f7XaMmBL+w2TTaxXocr//3FZzPwjb36hh6Q QEDiuxLW+W1MqgX8CcF7y5G4Wg4DAO3zh+/qobHTOzOH8R4dLWn+f0eBZCXTHO1KLLPeuSviUS2HG hgONULu/WW4BrAeyvyUAV8cpf6RIetxn8RKP8SjLkMV9wgP0Mq/zEo4fPmY1XqqMVsNZiN+tVnh0h vDgtN6OIO+fz0+7pL8JfoKui1rhPobfWeM+yNplBiwimcnPesXLnHyemJsKaqBof7N0nE5Uun7QS6 d4HDc/pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7aaL-0000000EtWe-12bV; Fri, 18 Sep 2026 15:33:09 +0000 Received: from smtp.forwardemail.net ([121.127.44.73]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7aaD-0000000EtTe-3T6M for linux-riscv@lists.infradead.org; Fri, 18 Sep 2026 15:33:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: To: From: Subject: Cc: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789745580; bh=WtQrZyaQlO+mtHmYw2SBSJxPWTjmzlVgI7Rp9b5tPg4=; b=ldxBSWsfj2jgBwIahVtK6wfb0yMfc+oHlano5WllFM3kNZqu4xFldgJcayXHv7UhliwB+uOtM JVSWE5jRLxRUgBrigZPxz0crLvvsKNIwNlW6b9c79NHiSKURYfNWKl0us3uqMC3HdB/WmQCGQ9u FOQ5IIUnuemOQph3htwNJQjWYIritvdQblFK4F9jWL42WSy7JajdwPWKUTYdqIDnsTl6QpMdqSv 6Xk7sLb3ORuMXNP061BSyZk+eOPA8pYqjf2Npcq1tSFUraLKQ76/DbTOMJ1uZOo+lIsF1upu9np lO1VU8FHtzKGGrv0EgDJCWgu1MnGPAQMJnSuuJNKFiUw== X-Forward-Email-ID: 6aad59a12df78bc22ddeff38 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Date: Fri, 18 Sep 2026 11:32:45 -0400 Message-Id: Cc: , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Subject: Re: [PATCH v4 00/20] drm: starfive: jh7110: Enable display subsystem From: "Joshua Peisach" To: "Michal Wilczynski" , "Joshua Peisach" , "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <136d6789-2f0c-4a91-ab2d-de3a3f119d5d@samsung.com> In-Reply-To: <136d6789-2f0c-4a91-ab2d-de3a3f119d5d@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_083301_911534_CBC5B951 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="Flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu Sep 17, 2026 at 1:22 PM EDT, Michal Wilczynski wrote: > > > On 9/16/26 02:45, Joshua Peisach wrote: >> On Tue Sep 15, 2026 at 11:32 AM EDT, Michal Wilczynski wrote: >>> >>> Testing >>> ======= >>> >>> Tested on a VisionFive 2 v1.3B using modetest. >> >> I.. got nothing. I did have to manually modprobe the modules, but >> unless I am doing something wrong.. I didn't get anything and modetest >> just gave -2. > > Hmm have you also changed the DTB not just the kernel and the modules > (you can also built in everything). > Yes (I didn't built-in everything, but I did make sure the DTB was copied and flash-kernel was run) > Also note modetest needs -M verisilicon. > "failed to open device 'versilicon' with busid '(null)': No such file or directory" > If that is not it, could you send "dmesg | grep -iE > 'verisilicon|inno|hdmi|vout'" and "ls /sys/class/drm/"? > the dmesg output: [ 0.090950] /soc/display-subsystem@29400000/hdmi@29590000/controller: Fixed dependency cycle(s) with /soc/display-subsystem@29400000/display@29400000 [ 0.091029] /soc/display-subsystem@29400000/display@29400000: Fixed dependency cycle(s) with /soc/display-subsystem@29400000/hdmi@29590000/controller [ 0.104227] /hdmi-connector: Fixed dependency cycle(s) with /soc/display-subsystem@29400000/hdmi@29590000/controller [ 0.104272] /soc/display-subsystem@29400000/hdmi@29590000/controller: Fixed dependency cycle(s) with /hdmi-connector /sys/class/drm only contains the file "version" -Josh >> >>> --- >>> Michal Wilczynski (20): >>> dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy >>> dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller >>> dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem >>> dt-bindings: soc: starfive: Add starfive,jh7110-vout-syscon >>> dt-bindings: display: verisilicon: Add starfive,jh7110-dc8200 >>> dt-bindings: soc: starfive: Add starfive,jh7110-vout-subsystem >>> drm/bridge: inno-hdmi: Split probe out of bind >>> drm/bridge: inno-hdmi: Allow the register map to come from a parent >>> drm/bridge: inno-hdmi: Add .disable platform operation >>> drm/bridge: inno-hdmi: Add .mode_valid platform operation >>> drm/bridge: inno-hdmi: Make the PHY configuration table optional >>> soc: starfive: Add jh7110-hdmi-subsystem driver >>> soc: starfive: Add jh7110-vout-subsystem driver >>> clk: starfive: jh7110-vout: Allow pixel clock rate propagation >>> drm/bridge: starfive: Add JH7110 HDMI controller driver >>> phy: Add common Innosilicon HDMI PHY helpers >>> phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers >>> phy: starfive: Add jh7110-inno-hdmi-phy driver >>> riscv: dts: starfive: jh7110: Update DT for display subsystem >>> MAINTAINERS: Add StarFive JH7110 display subsystem entry >>> >>> .../starfive,jh7110-inno-hdmi-controller.yaml | 121 +++++ >>> .../bindings/display/verisilicon,dc.yaml | 1 + >>> .../mfd/starfive,jh7110-hdmi-subsystem.yaml | 95 ++++ >>> .../phy/starfive,jh7110-inno-hdmi-phy.yaml | 49 ++ >>> .../soc/starfive/starfive,jh7110-syscon.yaml | 1 + >>> .../starfive/starfive,jh7110-vout-subsystem.yaml | 218 ++++++++ >>> MAINTAINERS | 13 + >>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 121 ++++- >>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 105 +++- >>> drivers/clk/starfive/clk-starfive-jh7110-vout.c | 6 +- >>> drivers/gpu/drm/bridge/Kconfig | 11 + >>> drivers/gpu/drm/bridge/Makefile | 1 + >>> drivers/gpu/drm/bridge/inno-hdmi.c | 112 +++- >>> drivers/gpu/drm/bridge/jh7110-inno-hdmi.c | 297 +++++++++++ >>> drivers/phy/Kconfig | 8 + >>> drivers/phy/Makefile | 1 + >>> drivers/phy/phy-inno-hdmi.c | 298 +++++++++++ >>> drivers/phy/rockchip/Kconfig | 1 + >>> drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 168 +----- >>> drivers/phy/starfive/Kconfig | 20 + >>> drivers/phy/starfive/Makefile | 1 + >>> drivers/phy/starfive/phy-jh7110-inno-hdmi.c | 579 +++++++++++++++++++++ >>> drivers/soc/Kconfig | 1 + >>> drivers/soc/Makefile | 1 + >>> drivers/soc/starfive/Kconfig | 43 ++ >>> drivers/soc/starfive/Makefile | 3 + >>> drivers/soc/starfive/jh7110-hdmi-subsystem.c | 73 +++ >>> drivers/soc/starfive/jh7110-vout-subsystem.c | 82 +++ >>> include/drm/bridge/inno_hdmi.h | 10 +- >>> include/linux/phy/inno-hdmi-phy.h | 85 +++ >>> 30 files changed, 2337 insertions(+), 188 deletions(-) >>> --- >>> base-commit: fd73f4a6659897191fa0d40695fe370925dd3780 >>> change-id: 20251031-jh7110-clean-send-7d2242118026 >>> >>> Best regards, >> >> By the way, something weird happenined while I applied the patches >> using git am. Somehow, some were out of order. The 10th patch >> adding .mode_valid tried to be applied before .disable even though >> in the series, the order is correctly set? git would obviously >> fail because the .disable entry did not exist in the header, so I had >> to manually put those in. >> >> I guess it's possible that something went wrong here? I personally >> pulled the mailbox from the lore.kernel.org mbox.gz file. > > I would recommend using b4 shazam instead > >> > > Best regards, _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv