From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Aurelien Jarno <aurelien@aurel32.net>,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Sebastian Reichel <sre@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: "open list:SYSTEM RESET/SHUTDOWN DRIVERS"
<linux-pm@vger.kernel.org>,
"open list:RISC-V SPACEMIT SoC Support"
<linux-riscv@lists.infradead.org>,
"open list:RISC-V SPACEMIT SoC Support"
<spacemit@lists.linux.dev>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Subject: Re: [PATCH 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
Date: Sun, 28 Sep 2025 10:08:58 +0800 [thread overview]
Message-ID: <E15EF3B2FD46EFE7+aNiYuset7FKRo_4C@kernel.org> (raw)
In-Reply-To: <20250927220824.1267318-3-aurelien@aurel32.net>
Hi Aurelien, Thanks for your patch!
On Sun, Sep 28, 2025 at 12:07:41AM +0200, Aurelien Jarno wrote:
> Add a "spacemit-p1-reboot" cell for the SpacemiT P1 chip.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/mfd/simple-mfd-i2c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index 696b602051260..2e86efb0c82b8 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -99,6 +99,7 @@ static const struct regmap_config spacemit_p1_regmap_config = {
> };
>
> static const struct mfd_cell spacemit_p1_cells[] = {
> + { .name = "spacemit-p1-reboot", },
I’m not sure if this name is the best fit here.
Since the driver also implements reboot and power-off functionality,
would it make more sense to call it spacemit-p1-power?
I’ll leave it up to you.
Otherwise, LGTM.
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> { .name = "spacemit-p1-regulator", },
> { .name = "spacemit-p1-rtc", },
> };
> --
> 2.47.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-28 2:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 22:07 driver: reset: spacemit-p1: add driver for poweroff/reboot Aurelien Jarno
2025-09-27 22:07 ` [PATCH 1/2] " Aurelien Jarno
2025-09-28 0:02 ` Yixun Lan
2025-09-28 18:01 ` Aurelien Jarno
2025-09-28 2:10 ` Troy Mitchell
2025-09-29 6:35 ` Troy Mitchell
2025-09-27 22:07 ` [PATCH 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip Aurelien Jarno
2025-09-28 2:08 ` Troy Mitchell [this message]
2025-09-28 21:01 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15EF3B2FD46EFE7+aNiYuset7FKRo_4C@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=aurelien@aurel32.net \
--cc=dlan@gentoo.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=spacemit@lists.linux.dev \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox