Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards

From: Shengyu Qu <wiagn233@outlook.com>
To: Conor Dooley <conor@kernel.org>
Cc: wiagn233@outlook.com, kernel@esmil.dk, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, william.qiu@starfivetech.com,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
Date: Thu, 13 Jun 2024 00:41:17 +0800	[thread overview]
Message-ID: <TY3P286MB2611CD8A6D480D1893BA833898C02@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240612-various-verbose-8c1a5db7d25a@spud>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1816 bytes --]

Hi Conor,

 From star64's schematic, I didn't see any difference between star64 and
vf2's emmc vqmmc source design and aldo4 is not shared with other
peripheral at all. And this patch is tested on my vf2 with no problem at
all. So I think it is supported.

Best regards,
Shengyu

在 2024/6/13 0:18, Conor Dooley 写道:
> On Wed, Jun 12, 2024 at 06:33:31PM +0800, Shengyu Qu wrote:
>> Currently, for JH7110 boards with EMMC slot, vqmmc voltage for EMMC is
>> fixed to 1.8V, while the spec needs it to be 3.3V on low speed mode and
>> should support switching to 1.8V when using higher speed mode. Since
>> there are no other peripherals using the same voltage source of EMMC's
>> vqmmc(ALDO4) on every board currently supported by mainline kernel,
> 
> I should've asked last time around, does the star64 also support 3.3
> volts?
> 
>> regulator-max-microvolt of ALDO4 should be set to 3.3V.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
>> Fixes: 7dafcfa79cc9 ("riscv: dts: starfive: enable DCDC1&ALDO4 node in axp15060")
>> ---
>>   arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> index 37b4c294ffcc..c7a549ec7452 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> @@ -244,7 +244,7 @@ emmc_vdd: aldo4 {
>>   				regulator-boot-on;
>>   				regulator-always-on;
>>   				regulator-min-microvolt = <1800000>;
>> -				regulator-max-microvolt = <1800000>;
>> +				regulator-max-microvolt = <3300000>;
>>   				regulator-name = "emmc_vdd";
>>   			};
>>   		};
>> -- 
>> 2.39.2
>>

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv