From: Conor Dooley <conor.dooley@microchip.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: <linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Qinglin Pan <panqinglin00@gmail.com>
Subject: Re: [PATCH] riscv: hwcap: Don't alphabetize ISA extension IDs
Date: Thu, 9 Feb 2023 13:55:17 +0000 [thread overview]
Message-ID: <Y+T7RQU/069DPwOF@wendy> (raw)
In-Reply-To: <20230209123636.123537-1-ajones@ventanamicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 1130 bytes --]
On Thu, Feb 09, 2023 at 01:36:36PM +0100, Andrew Jones wrote:
> While the comment above the ISA extension ID definitions says
> "Entries are sorted alphabetically.", this stopped being good
> advice with commit d8a3d8a75206 ("riscv: hwcap: make ISA extension
> ids can be used in asm"), as we now use macros instead of enums.
Yes, this ideally would have been removed by the commit doing the swap
over, but as both were in-flight simultaneously it was missed.
I intended going looking to see if this was dangling but clearly forgot.
> Reshuffling defines is error-prone, so, since they don't need to be
> in any particular order, change the advice to just adding new
> extensions at the bottom.
This aligns with what we "agreed" on Jisheng's patchset was the sanest
way to handle this.
> Also, take the opportunity to change
> spaces to tabs, merge three comments into one, and move the base
> and max defines into more logical locations wrt the ID definitions.
Sure, why not...
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for fixing this up Drew!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-09 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:36 [PATCH] riscv: hwcap: Don't alphabetize ISA extension IDs Andrew Jones
2023-02-09 13:55 ` Conor Dooley [this message]
2023-02-22 15:00 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+T7RQU/069DPwOF@wendy \
--to=conor.dooley@microchip.com \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=panqinglin00@gmail.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox