Re: [PATCH 2/2] RISC-V: improve string-function assembly

Andrew Jones
2023-02-09T08:26:07Z

On Wed, Feb 08, 2023 at 11:53:28PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@vrull.eu>
>
> Adapt the suggestions for the assembly string functions that Andrew
> suggested but that I didn't manage to include into the series that
> got applied.
>
> This includes improvements to two comments, removal of unneeded labels
> and moving one instruction slightly higher to contradict an
> explanatory comment.
>
> Suggested-by: Andrew Jones <ajones@ventanamicro.com>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
> ---
> arch/riscv/lib/strcmp.S | 6 ++++--
> arch/riscv/lib/strlen.S | 10 +++++-----
> arch/riscv/lib/strncmp.S | 16 +++++++---------
> 3 files changed, 16 insertions(+), 16 deletions(-)
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>