From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9478DC05027 for ; Sun, 12 Feb 2023 18:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LVOMjn9guyaBll7JMaYy5cTVD2a9GifYiBz1Q88Y9TY=; b=iDOy+mjCxAnTbhPdOGxYr6YOwz TbB/bmYl4W1CSpnpEHp5Q/u+ndXDCTQN+9/y4Mup+SNpy5xkzQhk8mqCk3bzAwv2v0E1n1sQ3t7Vd ciIUnnKvslcSfAJXOa4T9h+Pg9BXA2+V3m668XRzWXxDulgWNb8fMJv7sDVsJJ8KFAArj11cH4pLt Il79xtIRh8rDP38+YsHVSoWmG8wkiVPRpVgg1mzocHvWFiveCFMaHzgTQmFPVh5xzJzhrmMgVm/R3 dIt20TvuaXJkpp62mizIZPVnpi/3E+uQbbbLvgK7xdkAC5Ms41Lca5YoGoBfG4POMbMEdztdAJkdV b42ppQ8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRHM9-00C6a1-8R; Sun, 12 Feb 2023 18:45:45 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRHM5-00C6ZG-Lp; Sun, 12 Feb 2023 18:45:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2BB0EB80D31; Sun, 12 Feb 2023 18:45:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9054C433D2; Sun, 12 Feb 2023 18:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676227537; bh=tnPPngd7rmN7Pd2Bo0dYoAqjVVSybHD1OGhV6WT90xY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RM9IOqTjeWw0/KN0HrtxeHjqXD2NWfOZcl1FbykdM0ov+L7jSzNVuXivB0pxBFMdl SvY5UyIxpX7L63OFiOLV4FEDR/8jJDWOrWAR3mVEQJGNkyZIbR7QqG1p0MtrjCgR3F utGyi3uRel5KKLb6j1kR8aRnYNMBPbuB7HWEG0y4aTDvTazvFSDjJWYsIA9ukt+SUV UbJtrHYd0uwiwoN3wR796y5TS+AFiXdkdUnLhkVkTOn8ilNdqt2nAkQVMiBca549lz ZUkwLownwlITqHxmjbMOI4cr4neYYWkuPdC9quVnQB2RZiPMBpn4HN+r4QBfqZsQ2s olHbyibjmDLIg== Date: Sun, 12 Feb 2023 18:45:31 +0000 From: Conor Dooley To: Guenter Roeck Cc: Jisheng Zhang , Palmer Dabbelt , Paul Walmsley , Albert Ou , Anup Patel , Atish Patra , Heiko Stuebner , Andrew Jones , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v5 00/13] riscv: improve boot time isa extensions handling Message-ID: References: <20230128172856.3814-1-jszhang@kernel.org> <20230212154333.GA3760469@roeck-us.net> <48d2ac96-abdd-23bc-b167-08dc2c1a1dbe@roeck-us.net> MIME-Version: 1.0 In-Reply-To: <48d2ac96-abdd-23bc-b167-08dc2c1a1dbe@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230212_104542_024942_1FC097AA X-CRM114-Status: GOOD ( 31.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0247247972433353112==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============0247247972433353112== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UYsJLzonAkMi3tM1" Content-Disposition: inline --UYsJLzonAkMi3tM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 10:38:26AM -0800, Guenter Roeck wrote: > On 2/12/23 10:20, Conor Dooley wrote: > > On Sun, Feb 12, 2023 at 10:14:13AM -0800, Guenter Roeck wrote: > > > On 2/12/23 10:06, Conor Dooley wrote: > > > > On Sun, Feb 12, 2023 at 05:06:09PM +0000, Conor Dooley wrote: > > > > > On Sun, Feb 12, 2023 at 04:33:58PM +0000, Conor Dooley wrote: > > > > > > On Sun, Feb 12, 2023 at 03:59:59PM +0000, Conor Dooley wrote: > > > > >=20 > > > > > So as not to lead anyone up the garden path, let me correct mysel= f: > > > > >=20 > > > > > > Hmm, so this appears to be us attempting to patch in alternativ= es where > > > > > > none actually exists - seemingly F & D. > > > > >=20 > > > > > And of course that's not true, riscv_has_extension_likely() now u= ses > > > > > alternatives as of: > > > > > bdda5d554e43 ("riscv: introduce riscv_has_extension_[un]likely()") > > > > >=20 > > > > > From a quick look, it just happens that the only users are F & = D. > > > > >=20 > > > >=20 > > > > Samuel pointed out that this is a lockdep splat on irc. > > > > There's a patch on the list that removes the lockdep annotation > > > > entirely: > > > > https://patchwork.kernel.org/project/linux-riscv/patch/202302021141= 16.3695793-1-changbin.du@huawei.com/ > > > >=20 > > > > So ye, no surprises that it was config based! > > > >=20 > > > > Palmer posted a "better" fix for that lockdep warning a while ago: > > > > https://lore.kernel.org/all/20220322022331.32136-1-palmer@rivosinc.= com/ > > > >=20 > > > > So we'd have to duplicate/reuse that for cpufeature/errata patching. > > > >=20 > > > >=20 > > >=20 > > > This does not (only) happen in stop_machine(). > >=20 > > Yah, sorry I meant that it's the same lockdep splat as is being > > addressed there. > > The first patch deletes the lockdep stuff entirely, so removes the > > splat. I was thinking that we'd need to take Palmer's (IMO better) > > patch and do the same thing for patching alternatives, but I figure we > > can just take the text_mutex itself for alternatives & not have to > > dance around the lock. > >=20 > > I'll go do that I suppose! >=20 > Thanks a lot for the clarification. That sounds like the backtrace > can be largely ignored. Yeah, sorry that I phrased that confusingly in the first place. > However, I still see that the patch series > results in boot hangs with the sifive_u qemu emulation, where > the log ends with "Oops - illegal instruction". Is that problem > being addressed as well ? Hmm, if it died on the last commit in this series, then I am not sure. If you meant with riscv/for-next or linux-next that's fixed by a patch =66rom Samuel: https://patchwork.kernel.org/project/linux-riscv/patch/20230212021534.59121= -3-samuel@sholland.org/ Cheers, Conor. --UYsJLzonAkMi3tM1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY+kzywAKCRB4tDGHoIJi 0gBGAP4k1y38xuLeW0feO86J6WPfcRHKXkpqSNJOsp3tA5EFmgD/ZOgAcxE1Wu5k jMaQUwn6jGt4r3URuDAAXxYfbvNYiwc= =wpnv -----END PGP SIGNATURE----- --UYsJLzonAkMi3tM1-- --===============0247247972433353112== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============0247247972433353112==--