From: Conor Dooley <conor@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-riscv@lists.infradead.org, yash.shah@sifive.com,
palmer@dabbelt.com, paul.walmsley@sifive.com
Subject: Re: [PATCH 2/2] soc: sifive: ccache: fix missing free_irq() in error path in sifive_ccache_init()
Date: Mon, 17 Oct 2022 16:49:30 +0100 [thread overview]
Message-ID: <Y015irop2kUQ1yjG@spud> (raw)
In-Reply-To: <20221017084411.3557098-2-yangyingliang@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
On Mon, Oct 17, 2022 at 04:44:11PM +0800, Yang Yingliang wrote:
> Add missing free_irq() before return error from sifive_ccache_init().
>
> Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/soc/sifive/sifive_ccache.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/sifive/sifive_ccache.c b/drivers/soc/sifive/sifive_ccache.c
> index 25019c16d8ae..98269d056728 100644
> --- a/drivers/soc/sifive/sifive_ccache.c
> +++ b/drivers/soc/sifive/sifive_ccache.c
> @@ -240,7 +240,7 @@ static int __init sifive_ccache_init(void)
> NULL);
> if (rc) {
> pr_err("Could not request IRQ %d\n", g_irq[i]);
> - goto err_unmap;
> + goto err_free_irq;
> }
> }
>
> @@ -254,6 +254,9 @@ static int __init sifive_ccache_init(void)
> #endif
> return 0;
>
> +err_free_irq:
> + while (--i >= 0)
> + free_irq(g_irq[i], NULL);
> err_unmap:
> iounmap(ccache_base);
> return rc;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-10-17 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 8:44 [PATCH 1/2] soc: sifive: ccache: fix missing iounmap() in error path in sifive_ccache_init() Yang Yingliang
2022-10-17 8:44 ` [PATCH 2/2] soc: sifive: ccache: fix missing free_irq() " Yang Yingliang
2022-10-17 15:49 ` Conor Dooley [this message]
2022-10-17 15:46 ` [PATCH 1/2] soc: sifive: ccache: fix missing iounmap() " Conor Dooley
2022-10-18 1:50 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y015irop2kUQ1yjG@spud \
--to=conor@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=yangyingliang@huawei.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox