Re: [PATCH 8/9] RISC-V: Select APLIC and IMSIC drivers for QEMU virt machine

Conor Dooley
2022-11-15T22:29:52Z

Hey Anup,

On Fri, Nov 11, 2022 at 10:12:06AM +0530, Anup Patel wrote:
> The QEMU virt machine supports APLIC and IMSIC emulation so let's
> select APLIC and IMSIC drivers from SOC_VIRT kconfig option.

I'm kinda torn with this as I've been trying to get rid of the selects
from the file in the first place. As Maz seems to have decided that the
SiFive plic driver is really the RISC-V plic driver - is there a reason
not to either:
- select the sifive plic at an arch level, or
- put a "default RISCV" type thing in the driver entry?

Similarly here, should we default the APLIC and IMSIC drivers to enabled
for RISCV rather than using selects?

>
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
> arch/riscv/Kconfig.socs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 69774bb362d6..c16b32eeadff 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -35,6 +35,8 @@ config SOC_VIRT
> select GOLDFISH
> select RTC_DRV_GOLDFISH if RTC_CLASS
> select SIFIVE_PLIC
> + select RISCV_APLIC
> + select RISCV_IMSIC
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select RISCV_SBI_CPUIDLE if CPU_IDLE && RISCV_SBI
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv