Re: [PATCH v9 1/3] riscv: mm: modify pte format for Svnapot

Conor.Dooley
2022-12-08T04:59:29Z

On 08/12/2022 04:51, Qinglin Pan wrote:
> On 2022/12/8 02:46, Conor Dooley wrote:
>> On Sun, Dec 04, 2022 at 10:11:35PM +0800, panqinglin2020@iscas.ac.cn wrote:
>>> From: Qinglin Pan <panqinglin2020@iscas.ac.cn>

>>> +#define for_each_napot_order(order)                                         \
>>> +    for (order = NAPOT_CONT_ORDER_BASE; order < NAPOT_ORDER_MAX; order++)
>>> +#define for_each_napot_order_rev(order)                                             \
>>
>> Would it be terrible to do s/rev/reverse to make things more obvious?
>
> Maybe we should just keep it in the same style as existing macros like
> for_each_mem_range/for_each_mem_range_rev :)

Yah, makes sense. Sorry for the noise then!