Re: [PATCH v2 02/13] RISC-V: detach funct-values from their offset

Heiko Stübner
2022-11-30T14:19:37Z

Am Mittwoch, 30. November 2022, 15:16:58 CET schrieb Andrew Jones:
> On Wed, Nov 30, 2022 at 03:04:44PM +0100, Heiko Stübner wrote:
> > Am Mittwoch, 30. November 2022, 00:01:10 CET schrieb Conor Dooley:
> > > Woops, I built this commit in isolation and:
> > > /stuff/linux/arch/riscv/kernel/kgdb.c:32:32: error: use of undeclared identifier 'MASK_JALR'
> > > DECLARE_INSN(jalr, MATCH_JALR, MASK_JALR)
> > > ^
> > > /stuff/linux/arch/riscv/kernel/kgdb.c:32:20: error: use of undeclared identifier 'MATCH_JALR'
> > > DECLARE_INSN(jalr, MATCH_JALR, MASK_JALR)
> > > ^
> >
> > actually that is patch1's fault, that added the prefixes in the first place,
> > and I've fixed it there.
>
> I guess I should have done my grepping for patch1's review with only it
> checked out...
>
> git rebase -i -x '<build command line>' <series-base-commit>

voodoo :-D

I'm doing that manually right now, I need to address Conor's comments
anyway ;-) .

Heiko