From: Jisheng Zhang <jszhang@kernel.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: guoren@kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] RISC-V: Align the shadow stack
Date: Fri, 2 Dec 2022 00:22:23 +0800 [thread overview]
Message-ID: <Y4jUv42SRiMh+nEH@xhacker> (raw)
In-Reply-To: <20221130023515.20217-1-palmer@rivosinc.com>
On Tue, Nov 29, 2022 at 06:35:14PM -0800, Palmer Dabbelt wrote:
> The standard RISC-V ABIs all require 16-byte stack alignment. We're
> only calling that one function on the shadow stack so I doubt it'd
> result in a real issue, but might as well keep this lined up.
>
> Fixes: 31da94c25aea ("riscv: add VMAP_STACK overflow detection")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> arch/riscv/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index be54ccea8c47..acdfcacd7e57 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -206,7 +206,7 @@ static DEFINE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)],
> * shadow stack, handled_ kernel_ stack_ overflow(in kernel/entry.S) is used
> * to get per-cpu overflow stack(get_overflow_stack).
> */
> -long shadow_stack[SHADOW_OVERFLOW_STACK_SIZE/sizeof(long)];
> +long shadow_stack[SHADOW_OVERFLOW_STACK_SIZE/sizeof(long)] __aligned(16);
> asmlinkage unsigned long get_overflow_stack(void)
> {
> return (unsigned long)this_cpu_ptr(overflow_stack) +
> --
> 2.38.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-01 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 2:35 [PATCH 1/2] RISC-V: Align the shadow stack Palmer Dabbelt
2022-11-30 2:35 ` [PATCH 2/2] RISC-V: Add some comments about the shadow and overflow stacks Palmer Dabbelt
2022-12-01 13:17 ` Guo Ren
2022-12-01 16:21 ` Jisheng Zhang
2022-11-30 2:47 ` [PATCH 1/2] RISC-V: Align the shadow stack Khem Raj
2022-11-30 2:50 ` Palmer Dabbelt
2022-11-30 2:56 ` Khem Raj
2022-11-30 3:00 ` Palmer Dabbelt
2022-12-01 16:22 ` Jisheng Zhang [this message]
2022-12-13 6:17 ` Palmer Dabbelt
2022-12-13 6:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4jUv42SRiMh+nEH@xhacker \
--to=jszhang@kernel.org \
--cc=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox