From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E87B2C43217 for ; Thu, 1 Dec 2022 19:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m7kO3GRNGTxANXwwZ8p4drGUl4XGcaQteAONalDixBE=; b=hHx4RqlMzFfnHK q+hXAg5yeyvqBCqNJ0hivaMRgrRpVMCEoxup1CQ7+Q5fcuBEOYo1i/GG76zyzzLmfZy/SR52b4Ak3 OH1tmV9fTY/r7bUNqA7wVSRS8/NVKu+a3ancPrRhQFA3kF262ZmGEVcoA3oyAlWtl0cnpAAXikeLo AW5dkSp5H/TNBin9tHwPEXgQyGxKhb7TebwwkixUSSDVhFTVAI5gU5We1ql9zyM/QD2pNWX5u3ODv T8qwf4lKMKmNTKIFo68gwn3Pbx7ouveXUccGuL17WJ4uJcUlDFam2FYR6UBTnJQ9TUqLlOvavCSXj gBNofwZXiVuG8EAvqzrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0pJt-00ALnY-Hm; Thu, 01 Dec 2022 19:34:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0pGI-00AHOC-Uy for linux-riscv@lists.infradead.org; Thu, 01 Dec 2022 19:30:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F925620E5; Thu, 1 Dec 2022 19:30:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97982C433C1; Thu, 1 Dec 2022 19:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669923021; bh=0RxRzmDFLKwQUSgOIo6SuPkpbO4W72b1VHA4ZTgHkqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ky2zh/RynzTEWtmlLZ/FHid1Dc0FH/RMY9FbFYHg35MAt2n3x+hASDaKqs0Mdqca2 6Jq6vyKb0SSIk0XYUf0YBuFb4SsFS+geQCDU29CkHxtL+Zh1Ht7ueAYPB0jbpnuVwU 9m8bpO/+SQL/qJ5hoAlSHPHaRgf0UgiUbf2Q8ewt2tRKhk/2NR3I+pbgeUjg5efupC 7or94wbkXOf/FQ+utb7pR2kUSY5V6Qn5Al9EttMPjKkhs2Q1O3DOAEug0zrKH5sjAN 5nmr13FJTgwJXsiwqTL8xcH7bu3pv39GJo+iw+/xvM3fIg0YlcQXYzGe4KwEByGcoD KBg0Ab6Upl0+A== Date: Thu, 1 Dec 2022 19:30:16 +0000 From: Conor Dooley To: Yanhong Wang Cc: linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis Subject: Re: [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration Message-ID: References: <20221201090242.2381-1-yanhong.wang@starfivetech.com> <20221201090242.2381-8-yanhong.wang@starfivetech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_113023_100339_4BFEF53E X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 05:49:08PM +0000, Conor Dooley wrote: > On Thu, Dec 01, 2022 at 05:02:42PM +0800, Yanhong Wang wrote: > > riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration > > > > Add phy delay_chain configuration to support motorcomm phy driver for > > StarFive VisionFive 2 board. nit: please re-word this commit next time around to actually say what you're doing here. I didn't notice it initially, but this patch is doing a lot more than adding `delay_chain` configuration. To my dwmac unaware brain, there's nothing hits for that term outside of the changelog :( Thanks, Conor. > > > > Signed-off-by: Yanhong Wang > > --- > > .../jh7110-starfive-visionfive-v2.dts | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > index c8946cf3a268..2868ef4c74ef 100644 > > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-v2.dts > > @@ -15,6 +15,8 @@ > > > > aliases { > > serial0 = &uart0; > > + ethernet0=&gmac0; > > + ethernet1=&gmac1; > > Please match the whitespace usage of the existing entry. > > > }; > > > > chosen { > > @@ -114,3 +116,47 @@ > > pinctrl-0 = <&uart0_pins>; > > status = "okay"; > > }; > > + > > +&gmac0 { > > + status = "okay"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + phy-handle = <&phy0>; > > + status = "okay"; > > + mdio0 { > > A line of whitespace before the child nodes too please :) > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "snps,dwmac-mdio"; > > + phy0: ethernet-phy@0 { > > + reg = <0>; > > + rxc_dly_en = <1>; > > + tx_delay_sel_fe = <5>; > > + tx_delay_sel = <0xa>; > > + tx_inverted_10 = <0x1>; > > + tx_inverted_100 = <0x1>; > > + tx_inverted_1000 = <0x1>; > > + }; > > + }; > > +}; > > + > > +&gmac1 { > > + status = "okay"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + phy-handle = <&phy1>; > > + status = "okay"; > > + mdio1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "snps,dwmac-mdio"; > > + phy1: ethernet-phy@1 { > > + reg = <1>; > > + tx_delay_sel_fe = <5>; > > + tx_delay_sel = <0>; > > + rxc_dly_en = <0>; > > + tx_inverted_10 = <0x1>; > > + tx_inverted_100 = <0x1>; > > + tx_inverted_1000 = <0x0>; > > + }; > > + }; > > +}; > > -- > > 2.17.1 > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv