Re: [PATCH v1 3/3] riscv: dts: starfive: Add mmc node

William Qiu
2022-12-09T11:31:32Z

On 2022/12/9 5:15, Linus Walleij wrote:
> Hi William,
>
> thanks for your patch!
>
> On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@starfivetech.com> wrote:
>
>> + starfive,sys-syscon = <&sys_syscon 0x14 0x1a 0x7c000000>;
> (...)
>> + starfive,sys-syscon = <&sys_syscon 0x9c 0x1 0x3e>;
>
> These are registster offsets and shifts. Don't define such stuff in your device
> tree, use #defines in the code and just provide the phandle.
>

Hi Linus,

I will use #define in code instead in device tree.
Thank you for taking time to review and provide helpful comments for this patch.

Best Regards,
William Qiu
> Yours,
> Linus Walleij