Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive

William Qiu
2022-12-08T10:03:21Z

On 2022/12/8 17:01, Krzysztof Kozlowski wrote:
> On 08/12/2022 09:44, William Qiu wrote:
>>
>>>> +
>>>> + clock-names:
>>>> + minItems: 1
>>>> + items:
>>>> + - const: biu
>>>> + - const: ciu
>>>> +
>>>> + interrupts:
>>>> + maxItems: 1
>>>> +
>>>> + starfive,sys-syscon:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>>> + description:
>>>> + The desired number of times that the host execute tuning when needed.
>>>
>>> That's not matching the property name. Missing number of items... this
>>> is anyway confusing. Why number of tuning tries is a property of DT?
>>>
>>
>> Will update the description.
>
> I propose first to explain what is it. Because it is not about
> description only, but also type. Your driver uses this as syscon, so
> this cannot be uint32-array but phandle-array...
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

Thank you for suggestion and I'll take it. I'll update it in next
version.

Best regards,
William Qiu