From: Conor Dooley <conor@kernel.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
linux-riscv <linux-riscv@lists.infradead.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Christoph Müllner" <christoph.muellner@vrull.eu>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Andrew Jones" <ajones@ventanamicro.com>,
emil.renner.berthing@canonical.com,
"Jisheng Zhang" <jszhang@kernel.org>,
"Heiko Stuebner" <heiko.stuebner@vrull.eu>
Subject: Re: [PATCH v4 12/12] RISC-V: fix auipc-jalr addresses in patched alternatives
Date: Wed, 7 Dec 2022 22:04:19 +0000 [thread overview]
Message-ID: <Y5EN44bscFwFYrUv@spud> (raw)
In-Reply-To: <F5E250D9-29DD-40C5-AF34-82B59DD4BD11@jrtc27.com>
[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]
On Wed, Dec 07, 2022 at 10:00:13PM +0000, Jessica Clarke wrote:
> >> +static u32 riscv_instruction_at(void *p)
> >> +{
> >> + u16 *parcel = p;
> >> +
> >> + return (unsigned int)parcel[0] | (unsigned int)parcel[1] << 16;
> >
> > I feel bad for not mentioning this before - can we replace this magic 16
> > with something self documenting?
>
> I mean, it’s a u16 * two lines above, that seems a bit unnecessary...
I guess that's why I didn't mention it before... Can safely disregard
that request so Heiko!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-07 22:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 18:08 [PATCH v4 00/12] Allow calls in alternatives Heiko Stuebner
2022-12-07 18:08 ` [PATCH v4 01/12] RISC-V: fix funct4 definition for c.jalr in parse_asm.h Heiko Stuebner
2022-12-10 12:34 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 02/12] RISC-V: add prefix to all constants/macros " Heiko Stuebner
2022-12-10 12:45 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 03/12] RISC-V: detach funct-values from their offset Heiko Stuebner
2022-12-10 22:16 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 04/12] RISC-V: add ebreak instructions to definitions Heiko Stuebner
2022-12-10 23:08 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 05/12] RISC-V: add auipc elements to parse_asm header Heiko Stuebner
2022-12-10 23:28 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 06/12] RISC-V: Move riscv_insn_is_* macros into a common header Heiko Stuebner
2022-12-11 17:32 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 07/12] RISC-V: rename parse_asm.h to insn.h Heiko Stuebner
2022-12-11 17:33 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 08/12] RISC-V: kprobes: use central defined funct3 constants Heiko Stuebner
2022-12-11 17:34 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 09/12] RISC-V: add U-type imm parsing to insn.h header Heiko Stuebner
2022-12-11 17:36 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 10/12] RISC-V: add rd reg " Heiko Stuebner
2022-12-11 17:41 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 11/12] RISC-V: add helpers for handling immediates in U-type and I-type pairs Heiko Stuebner
2022-12-07 20:07 ` Conor Dooley
2022-12-07 22:43 ` Heiko Stuebner
2022-12-08 14:38 ` Andrew Jones
2022-12-22 13:46 ` Heiko Stübner
2022-12-11 20:45 ` Lad, Prabhakar
2022-12-07 18:08 ` [PATCH v4 12/12] RISC-V: fix auipc-jalr addresses in patched alternatives Heiko Stuebner
2022-12-07 20:48 ` Conor Dooley
2022-12-07 22:00 ` Jessica Clarke
2022-12-07 22:04 ` Conor Dooley [this message]
2022-12-07 22:37 ` Heiko Stuebner
2022-12-08 5:03 ` Conor.Dooley
2022-12-08 14:47 ` Andrew Jones
2022-12-11 20:49 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5EN44bscFwFYrUv@spud \
--to=conor@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=christoph.muellner@vrull.eu \
--cc=emil.renner.berthing@canonical.com \
--cc=heiko.stuebner@vrull.eu \
--cc=heiko@sntech.de \
--cc=jrtc27@jrtc27.com \
--cc=jszhang@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox