Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code

Paolo Bonzini
2022-12-12T22:55:02Z

On 12/9/22 20:07, Oliver Upton wrote:
>> - Naming. This series does not change the names of any existing code.
>> So all the KVM/x86 Shadow MMU-style terminology like
>> "shadow_page"/"sp"/"spte" persists. Should we keep that style in
>> common code or move toward something less shadow-paging-specific?
>> e.g. "page_table"/"pt"/"pte".
>
> I would strongly be in favor of discarding the shadow paging residue if
> x86 folks are willing to part ways with it 😄

Yes, absolutely. Something like to_shadow_page->to_mmu_data, sp->md,
spt->hpt, spte->spte, sptep->hptep.

Paolo