Re: [RFC PATCH 00/37] KVM: Refactor the KVM/x86 TDP MMU into common code

Sean Christopherson
2022-12-12T23:27:05Z

On Mon, Dec 12, 2022, Paolo Bonzini wrote:
> On 12/9/22 20:07, Oliver Upton wrote:
> > > - Naming. This series does not change the names of any existing code.
> > > So all the KVM/x86 Shadow MMU-style terminology like
> > > "shadow_page"/"sp"/"spte" persists. Should we keep that style in
> > > common code or move toward something less shadow-paging-specific?
> > > e.g. "page_table"/"pt"/"pte".
> >
> > I would strongly be in favor of discarding the shadow paging residue if
> > x86 folks are willing to part ways with it 😄
>
> Yes, absolutely. Something like to_shadow_page->to_mmu_data, sp->md,
> spt->hpt, spte->spte, sptep->hptep.

"host" will be confusing if when the primary MMU is involved though, e.g. I always
think of the primary MMU's page tables as the "host page tables".

What if we keep the "S" for SPT(E) and repurpose it to mean Secondary PTE?