Re: [PATCH v3 6/7] riscv: dts: starfive: Add initial StarFive JH7110 device tree

Krzysztof Kozlowski
2022-12-25T11:57:02Z

On 25/12/2022 11:31, Hal Feng wrote:

>
> gmac0_rmii_refin: clock {
> ...
> };
>
> gmac0_rgmii_rxin: clock {
> ...
> };
> ...
>
>> nothing. It looks like you avoid to define proper clock controller.
>> What's the point for all these clocks? These are no-op.
>
> These are all external fixed rate clocks inputted to the SoC. They are the root

If they are all external, then it is fine.

>
>>
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + };

Best regards,
Krzysztof