From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 765D5C4708E for ; Wed, 4 Jan 2023 01:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xNK+Nz2c68kAv0b7cTHhYexBg3JS/IAUfpud5FH55Jw=; b=T3lv1fJ9zHNGih KziivCvclGu8e75qFRO/R4nNoBaBjY/U5mF0HGVnHV1dPoO6hsVl9/uOAq7Zl27ss8oGZc74eaTfH vA7owQvJLFR/FaGdMYmp0kh/BNTfrq1bvHIlTLG6WSiX2XHWfFm30g8NCbgi+ihrV6e0bg965wowh KoMxkzmwAt7D58IUZTL2nOkANn6MsxuENkiLFzncuQT3rQEr5rPwy4+GX7ChMGfGULzOMwGvSLQLe 2vCCbXQbGP8dTI1x8DPkC1XPQhYjsA7A/c8t+PHe1hQjSueLwzHgnzsFopFaQu9c5Nz9i2zqeXV3R 9M3NXxNiqjIts0xJH1cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCsIB-0065T9-40; Wed, 04 Jan 2023 01:10:07 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCsHm-0065Oo-AV for linux-riscv@lists.infradead.org; Wed, 04 Jan 2023 01:09:43 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d15so34447671pls.6 for ; Tue, 03 Jan 2023 17:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2VT5QZhcZZeDbsiEz/fllfSXONvy51XdiSS8QokpwQg=; b=Q4DEfeoNUsJnujmG5WDcxlCAMaEfhBmMWAS7aUzEC2GW3ofbkRwZ22ZYFjITsxmo6K bb0vjmVJXZL0G/l4TGKr3KMTIDcdwQUeKoeFnx6I8MLcodY9TVH6AGEpkz9x9GWI5hwx k7R0UjHzbUt2Ai1wJRy2IFQHhF6DWYLx8cxQAFMWDWI6Xgrug2FARlR3RiNRVi4rCbo9 AP/OLiZNnuV7UvZFm8qEsAphMEm93ULbKnV9d+A7rgWdhM6aiDUP6a5tWQx2bF/ggq6A f7JPgRzWEeYZPXHV5Lm4ZgFljKv8WtzXvID2mUUKGwqdRm31BuBbvKfhkRXpKAhdOylW Zj3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2VT5QZhcZZeDbsiEz/fllfSXONvy51XdiSS8QokpwQg=; b=xCzPHlKXMJS37DkP0QU5Zjg5jS4esxEwtFL0bLe+fDQZgSWdsDbegocfPjmkd+NPNt xge+C0xs14+av4NAnXk/iPDo7vXUAh8teu1dzpNVN2NGnYqGD0pdHc8WO0I1Nl4OwiIG LGbTD5JbgonxdLdJFFw375A9hPsSTrCabRcyIXQH8fK/eu8D+gGuiIrn4VFh/jOLrSNW ki7WOu1aOsECg/lQtJlcX7fqqTqkknF7lwnSQGbB/XtLed3I9VB3LHJrPLg4jnMJyoag Ofp1Nb/6zttL6nysJt4EdOBrE1nc9Xs5B9BEK5LoqI7lpQT8R5Alx2ycQ/aQEm91pLmK 6Jvw== X-Gm-Message-State: AFqh2koXvGtJhpx/ypLBc0STCwp0YnULCFIRXkhdPSSw+FYeTez6SkWt cZWXtvBPcAFBWb36wP4+HZAiXw== X-Google-Smtp-Source: AMrXdXt4xHOajqscKlKaEpBiTyEw5HpxcS2+BmkjFSTy1AWvaTA2O2HtoOh9s0+BdQR2dE8QR1delA== X-Received: by 2002:a17:90a:9912:b0:219:f970:5119 with SMTP id b18-20020a17090a991200b00219f9705119mr3677621pjp.1.1672794579775; Tue, 03 Jan 2023 17:09:39 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id dw6-20020a17090b094600b00223f495dc28sm19707506pjb.14.2023.01.03.17.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 17:09:39 -0800 (PST) Date: Wed, 4 Jan 2023 01:09:35 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Tom Rix , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Ricardo Koller , Aaron Lewis , Raghavendra Rao Ananta Subject: Re: [PATCH 12/14] KVM: selftests: Use wildcards to find library source files Message-ID: References: <20221213001653.3852042-1-seanjc@google.com> <20221213001653.3852042-13-seanjc@google.com> <363f4713-6105-82d1-351e-423d07470cdf@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <363f4713-6105-82d1-351e-423d07470cdf@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_170942_442546_B40606A6 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Dec 24, 2022, Paolo Bonzini wrote: > On 12/13/22 01:16, Sean Christopherson wrote: > > Use $(wildcard ...) to find the library source files instead of manually > > defining the inputs, which is a maintenance burden and error prone. > > No, please don't. This leads to weird errors, for example when "git > checkout" is interrupted with ^C. Well, don't do that ;-) Are there concerns beyond having an incomplete and/or modified git working tree? E.g. could we do something crazy like fail the build by default if the working tree isn't pristine? The library files aren't terrible, but the number of tests is getting unwieldy, to say the least. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv