From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Ripard <mripard@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-staging@lists.linux.dev,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 3/4] media: cedrus: Make SRAM section claiming optional
Date: Thu, 5 Jan 2023 11:02:12 +0100 [thread overview]
Message-ID: <Y7agJBFqcvqyLNhK@aptenodytes> (raw)
In-Reply-To: <20221231164628.19688-4-samuel@sholland.org>
[-- Attachment #1.1: Type: text/plain, Size: 1347 bytes --]
Hi Samuel,
On Sat 31 Dec 22, 10:46, Samuel Holland wrote:
> The video engine in the D1 family of SoCs does not have a switchable
> SRAM section. Allow the driver to probe even when the SRAM section
> reference is missing.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Looks good, I've also just checked that calling sunxi_sram_release with no
reference to the SRAM held is fine (maybe a word about it in the commit log
would be nice, but probably not worth making a v2 just for that).
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> ---
>
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> index fa86a658fdc6..11e859617932 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> @@ -257,7 +257,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev)
> }
>
> ret = sunxi_sram_claim(dev->dev);
> - if (ret) {
> + if (ret && ret != -ENOENT) {
> dev_err(dev->dev, "Failed to claim SRAM\n");
>
> goto err_mem;
> --
> 2.37.4
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-05 20:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 16:46 [PATCH 0/4] Allwinner D1 video engine support Samuel Holland
2022-12-31 16:46 ` [PATCH 1/4] media: dt-bindings: cedrus: Allow power domain references Samuel Holland
2022-12-31 19:05 ` Krzysztof Kozlowski
2023-01-05 10:43 ` Paul Kocialkowski
2023-01-05 14:48 ` Samuel Holland
2023-01-05 16:18 ` Jernej Škrabec
2022-12-31 16:46 ` [PATCH 2/4] media: dt-bindings: cedrus: Make allwinner,sram optional Samuel Holland
2022-12-31 19:06 ` Krzysztof Kozlowski
2023-01-05 9:57 ` Paul Kocialkowski
2022-12-31 16:46 ` [PATCH 3/4] media: cedrus: Make SRAM section claiming optional Samuel Holland
2023-01-05 10:02 ` Paul Kocialkowski [this message]
2023-01-05 16:19 ` Jernej Škrabec
2022-12-31 16:46 ` [PATCH 4/4] riscv: dts: allwinner: d1: Add video engine node Samuel Holland
2023-01-05 10:11 ` Paul Kocialkowski
2023-01-05 14:38 ` Samuel Holland
2023-01-05 16:21 ` Jernej Škrabec
2023-02-15 0:25 ` Palmer Dabbelt
2023-01-23 12:33 ` [PATCH 0/4] Allwinner D1 video engine support Hans Verkuil
2023-01-24 5:11 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7agJBFqcvqyLNhK@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox