Re: [PATCH v4 07/12] riscv: dts: allwinner: Add Sipeed Lichee RV devicetrees

Paul Kocialkowski
2023-01-10T15:58:40Z

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

Hi Samuel,

On Sun 08 Jan 23, 12:42, Samuel Holland wrote:
> Hi Paul,
>
> On 1/5/23 07:55, Paul Kocialkowski wrote:
> > Hi Samuel,
> >
> > On Sat 31 Dec 22, 17:38, Samuel Holland wrote:
> >> Sipeed manufactures a "Lichee RV" system-on-module, which provides a
> >> minimal working system on its own, as well as a few carrier boards. The
> >> "Dock" board provides audio, USB, and WiFi. The "86 Panel" additionally
> >> provides 100M Ethernet and a built-in display panel.
> >>
> >> The 86 Panel repurposes the USB ID and VBUS detection GPIOs for its RGB
> >> panel interface, since the USB OTG port is inaccessible inside the case.
> >
> > Looks like the panel-enabled variants would better be described as device-tree
> > overlays as they are not specific devices but are peripheral extensions.
> >
> > What do you think?
>
> I don't agree. The Lichee RV 86 Panel is sold as a complete unit, with
> the SoM+board and LCD pre-assembled inside a case. It is not possible to
> purchase the board without a panel, so the panel-enabled variants are
> the only variants.

Oh my bad, I didn't go as far as actually checking what it looks like.
So yeah if it's an individual device on its own I agree it deserves its
own dedicated device-tree.

Cheers,

Paul

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]