Re: [PATCH] riscv: dts: fu740: fix size of pcie 32bit memory

From: Conor Dooley <conor@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>, Ron Economos <re@w6rz.net>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	robh+dt@kernel.org, palmer@dabbelt.com,
	krzysztof.kozlowski+dt@linaro.org, zong.li@sifive.com,
	linux-kernel@lists.codethink.co.uk,
	sudip.mukherjee@codethink.co.uk,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Greentime Hu <greentime.hu@sifive.com>
Subject: Re: [PATCH] riscv: dts: fu740: fix size of pcie 32bit memory
Date: Fri, 6 Jan 2023 14:55:51 +0000	[thread overview]
Message-ID: <Y7g2d+3BtIJfy1IH@spud> (raw)
In-Reply-To: <b64bfeff-e1e8-02d5-0a7d-c2a0a905da5e@codethink.co.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1296 bytes --]

On Fri, Jan 06, 2023 at 02:51:04PM +0000, Ben Dooks wrote:
> On 06/01/2023 14:07, Krzysztof Kozlowski wrote:
> > On 06/01/2023 14:44, Ben Dooks wrote:
> > > The 32-bit memory resource is needed for non-prefetchable memory
> > > allocations on the PCIe bus, however with some cards (such as the
> > > SM768) the system fails to allocate memory from this.
> > > 
> > > Checking the allocation against the datasheet, it looks like there
> > > has been a mis-calcualation of the resource for the first memory
> > > region (0x0060090000..0x0070ffffff) which in the data-sheet for
> > > the fu740 (v1p2) is from 0x0060000000..0x007fffffff. Changing
> > > this to allocate from 0x0060090000..0x007fffffff fixes the probing
> > > issues.
> > > 
> > > Fixes: ae80d514808557018e44190 ("riscv: dts: Add PCIe support for the SiFive FU740-C000 SoC
> > > ")
> > 
> > Don't wrap lines.
> > 
> > > 
> > 
> > Drop empty line between tags.
> 
> 
> Thanks, will fix.

I wouldn't bother resending to fix that stuff, can be done on
application.

I don't have a PCI card handy to test with so +CC Ron, perhaps he can
give this patch a go.

I can give it a go next week though probably if nothing's come through -
although likely not with something like an SM768.

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv